In Historical Retrieval (SDK) use project from client context#1138
Merged
pyalex merged 2 commits intofeast-dev:masterfrom Nov 5, 2020
Merged
In Historical Retrieval (SDK) use project from client context#1138pyalex merged 2 commits intofeast-dev:masterfrom
pyalex merged 2 commits intofeast-dev:masterfrom
Conversation
Signed-off-by: Oleksii Moskalenko <[email protected]>
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
Signed-off-by: Oleksii Moskalenko <[email protected]>
khorshuheng
approved these changes
Nov 5, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
@pyalex: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Collaborator
Author
|
/test test-end-to-end-gcp |
Collaborator
|
/lgtm |
Collaborator
Author
|
/test test-end-to-end-gcp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Moskalenko [email protected]
What this PR does / why we need it:
Previously it was mandatory to specify project in
get_historical_featuresandclient.projectwas not used, which is a bug.This PR proposes to sync signatures of
get_historical_features&start_offline_to_online_ingestionand use project from client context only.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: