Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: feast-dev/feast
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.7
Choose a base ref
...
head repository: feast-dev/feast
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.7
Choose a head ref
  • 17 commits
  • 105 files changed
  • 9 contributors

Commits on Dec 18, 2019

  1. Update helm dependency before building (#373)

    To ensure requirements.lock is in sync with requirements.yaml
    helm/helm#2033
    davidheryanto committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    ec0db7c View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. Make redis key creation more determinisitic (#380)

    * Make redis key creation more determinisitic
    
    * Sort entity names
    Chen Zhiling committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    decb44b View commit details
    Browse the repository at this point in the history
  2. Remove alpha v1 from java package name (#387)

    khorshuheng authored and Shu Heng committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    5801e58 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2019

  1. Always set destination table in BigQuery query config in Feast Batch …

    …Serving so it can handle large results (#392)
    
    * Update BQ query config to always set destination table, so that it can work with large results
    Refer to: https://cloud.google.com/bigquery/quotas#query_jobs, maximum reponse-size bullet point.
    
    * Replace prefix for temp table name
    
    * Set expiry on entity rows table
    
    * Include exception message in error description
    GRPC client such as Feast Python SDK will usually not show error cause only error description
    
    * Code cleanup
    
    * Update batch-retrieval e2e test.
    Output rows may not have the same order as requested entity rows
    davidheryanto authored and feast-ci-bot committed Dec 26, 2019
    Configuration menu
    Copy the full SHA
    2fcddaa View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2020

  1. Rebasing changes (#355)

    voonhous authored and davidheryanto committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    77229eb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5601a09 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d93274f View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Add missing wait time after running feast apply (#412)

    Otherwise ingested data will not be processed because Beam job is not ready
    davidheryanto authored and feast-ci-bot committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    cd7ab6d View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. Add Cassandra Store (#360)

    * create cassandra store for registration and ingestion
    
      * Downgraded Guava to 25
        * Beam 2.16 uses Cassandra 3.4.0 (So we cannot use Cassandra 4.x which shades Guava)
        * Cassandra 3.4.0 uses Guava version 16.0 but has a compatibility check to use a different class when we use version > 19.0.
        * Guava version 26 (version previously used) has breaking change to method used in compatibility check in Cassandra's dependency, hence version 25
      * Using Cassandra's internal field 'writetime' to handle out of order arrivals. When older records where the primary key already exist in Cassandra are ingested, they are set as tombstones in Cassandra and ignored on retrieval.
        * Aware that this way of handling out of order arrival is specific to Cassandra, but until we have a general way to handle out of order arrivals we need to do it this way
      * Cassandra's object mapper requires stating table's name along with @table annotation
        * table_name is still part of CassandraConfig for use in serving module
        * if user registers CassandraConfig with a different table name other than "feature_store", this will throw an exception
    
    * add cassandra serving service
    
      * Abstracted OnlineServingService for common implementation of online serving stores
      * Complete tests remain in RedisServingServiceTest while Cassandra tests only contain basic tests for writes, and some other implementation specific to Cassandra
    
    * update documentation to reflect current API and add cassandra store to docs
    
    * add default expiration to cassandra config for when featureset does not have max age
    
    * docs update, spotless check, and bug fix on cassandra schema
    smadarasmi authored and feast-ci-bot committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    505bdc6 View commit details
    Browse the repository at this point in the history
  2. Backport Sonatype publishing and datatypes module for v0.3.x (#407)

    * Use Nexus staging plugin for deployment (#394)
    
    * Use Nexus staging pluging for deployment
    
    * Fix Javadoc error
    
    * Hard coded parent version as variable substitution is not supported
    
    * Introduce datatypes/java module for proto generation
    
    Rather than the Maven protobuf plugin running on the same symlinked
    definitions in several Java modules, localize this process into one
    module that the others depend on.
    
    This provides a single module that can be depended on by third-party
    extensions with the bare minimum of dependencies.
    
    Also removes proto files that are no longer used.
    
    * Java SDK release script (#406)
    
    * Use back revision variable in pom.xml
    So user or CI system can easily override revision from external sources such as Git tag name
    
    * Add flatten maven plugin
    This plugin is useful during deployment so the final pom is resolved without parent dependency, i.e. we do not necessarily need to upload parent library
    
    * Increase versions for maven source,javadoc,spotless plugins
    So it has newer features and more fixes
    
    * Add gpg-plugin needed to sign releases
    
    * Use oss configure for flatten plugin, add developers info in pom.xml (required for releasing library
    
    * Add publish-java-sdk script
    
    * Add more logs to publish-java-sdk.sh
    
    * Add ProwJob publish-java-sdk
    
    * Use GPG_KEY_IMPORT_DIR variable
    
    * Update revision in pom.xml to 0.4.2-SNAPSHOT
    
    * Publish datatypes/java along with sdk/java
    
    Co-authored-by: Khor Shu Heng <[email protected]>
    Co-authored-by: David Heryanto <[email protected]>
    3 people authored and feast-ci-bot committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    801408a View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. Set version to 0.3.7-SNAPSHOT

    v0.3.6 was tagged and 0.3.x development has moved forward. See #442
    ches committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    784c7e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Configuration menu
    Copy the full SHA
    be47510 View commit details
    Browse the repository at this point in the history
  2. v0.3 backport: Fail Spotless check before tests (#516)

    * Fail formatting check before tests execute
    
    By default, the spotless Maven plugin binds its check goal to the verify
    phase (late in the lifecycle, after integration tests). Because we
    currently only run `mvn test` for CI, it doesn't proceed as far as
    verify so missed formatting is not caught by CI.
    
    This binds the check to an earlier phase, in between test-compile and
    test, so that it will fail before `mvn test` but not disrupt your dev
    workflow of compiling main and test sources as you work. This strikes a
    good compromise on failing fast for code standards without being _too_
    nagging.
    
    For the complete lifecycle reference, see:
    https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
    
    * Apply Spotless formatting
    
    Hopefully for last time as a bulk operation, after 6363540.
    ches authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    be4d189 View commit details
    Browse the repository at this point in the history
  3. v0.3 backport: Remove unused ingestion deps (#521)

    * Make dependency:analyze run clean on datatypes-java
    
    * Remove stale dependencies from ingestion
    
    Unused according to `mvn -pl ingestion dependency:analyze`, and tests.
    
    We had a recent bump of hibernate-validator with a CVE fix (#421) that I
    was looking to backport, and it turns out it's not used anymore anyway.
    ches authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    4f91b22 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Configuration menu
    Copy the full SHA
    1a35764 View commit details
    Browse the repository at this point in the history
  2. Add index for join table for jobs-featuresets relation (#566, #647)

    Chen Zhiling authored and ches committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    a68ddf2 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Release v0.3.7 (#670)

    * Release v0.3.7
    
    * Remove SNAPSHOT from e2e tests
    
    * Find jar version from Maven
    woop authored May 1, 2020
    Configuration menu
    Copy the full SHA
    987cb99 View commit details
    Browse the repository at this point in the history
Loading