Skip to content

Commit cc2410c

Browse files
franciscojavierarceofranciscojavierarceo
authored
chore: Fix actions to not run and give passing status on doc changes (#5271)
Signed-off-by: Francisco Javier Arceo <[email protected]>
1 parent c7e2da0 commit cc2410c

File tree

7 files changed

+52
-10
lines changed

7 files changed

+52
-10
lines changed

‎.github/workflows/java_pr.yml‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,18 @@ permissions:
1111
pull-requests: read
1212

1313
jobs:
14+
check_skip_tests:
15+
uses: ./.github/workflows/check_skip_tests.yml
16+
with:
17+
head-sha: ${{ github.event.pull_request.head.sha }}
18+
excluded-dirs: 'docs/**,tests/**,examples/**'
19+
1420
lint-java:
1521
# when using pull_request_target, all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes.
1622
if:
1723
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
1824
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
19-
github.repository == 'feast-dev/feast'
25+
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
2026
runs-on: ubuntu-latest
2127
steps:
2228
- uses: actions/checkout@v4
@@ -35,7 +41,7 @@ jobs:
3541
if:
3642
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
3743
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
38-
github.repository == 'feast-dev/feast'
44+
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
3945
runs-on: ubuntu-latest
4046
needs: lint-java
4147
steps:
@@ -77,7 +83,7 @@ jobs:
7783
if:
7884
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
7985
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
80-
github.repository == 'feast-dev/feast'
86+
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
8187
runs-on: ubuntu-latest
8288
strategy:
8389
matrix:
@@ -113,7 +119,7 @@ jobs:
113119
if:
114120
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
115121
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
116-
github.repository == 'feast-dev/feast'
122+
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
117123
runs-on: ubuntu-latest
118124
needs: unit-test-java
119125
env:

‎.github/workflows/operator-e2e-integration-tests.yml‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,18 @@ on:
1414
- 'infra/**'
1515

1616
jobs:
17+
check_skip_tests:
18+
uses: ./.github/workflows/check_skip_tests.yml
19+
with:
20+
head-sha: ${{ github.event.pull_request.head.sha }}
21+
excluded-dirs: 'docs/**,tests/**,examples/**'
22+
1723
operator-e2e-tests:
1824
timeout-minutes: 40
1925
if:
2026
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
2127
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
22-
github.repository == 'feast-dev/feast'
28+
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
2329
runs-on: ubuntu-latest
2430

2531
services:

‎.github/workflows/operator_pr.yml‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,14 @@ name: operator-pr
22

33
on: [pull_request]
44
jobs:
5+
check_skip_tests:
6+
uses: ./.github/workflows/check_skip_tests.yml
7+
with:
8+
head-sha: ${{ github.event.pull_request.head.sha }}
9+
excluded-dirs: 'docs/**,tests/**,examples/**'
10+
511
operator-test:
6-
if: ${{ !contains(github.event.pull_request.files, 'docs/') }} # Skip if docs files changed
12+
if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }}
713
runs-on: ubuntu-latest
814
steps:
915
- uses: actions/checkout@v4

‎.github/workflows/pr_integration_tests.yml‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,18 @@ permissions:
1616
pull-requests: read
1717

1818
jobs:
19+
check_skip_tests:
20+
uses: ./.github/workflows/check_skip_tests.yml
21+
with:
22+
head-sha: ${{ github.event.pull_request.head.sha }}
23+
excluded-dirs: 'docs/**,tests/**,examples/**'
24+
1925
integration-test-python:
2026
# when using pull_request_target, all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes.
2127
if:
2228
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
2329
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
24-
github.repository == 'feast-dev/feast'
30+
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
2531
runs-on: ${{ matrix.os }}
2632
strategy:
2733
fail-fast: false

‎.github/workflows/pr_local_integration_tests.yml‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,17 @@ on:
99
- labeled
1010

1111
jobs:
12+
check_skip_tests:
13+
uses: ./.github/workflows/check_skip_tests.yml
14+
with:
15+
head-sha: ${{ github.event.pull_request.head.sha }}
16+
excluded-dirs: 'docs/**,tests/**,examples/**'
17+
1218
integration-test-python-local:
1319
if:
1420
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
1521
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
16-
github.event.pull_request.base.repo.full_name == 'feast-dev/feast'
22+
github.event.pull_request.base.repo.full_name == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
1723
runs-on: ${{ matrix.os }}
1824
strategy:
1925
fail-fast: false

‎.github/workflows/pr_remote_rbac_integration_tests.yml‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,17 @@ on:
99
- labeled
1010

1111
jobs:
12+
check_skip_tests:
13+
uses: ./.github/workflows/check_skip_tests.yml
14+
with:
15+
head-sha: ${{ github.event.pull_request.head.sha }}
16+
excluded-dirs: 'docs/**,tests/**,examples/**'
17+
1218
remote-rbac-integration-tests-python:
1319
if:
1420
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
1521
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
16-
github.event.pull_request.base.repo.full_name == 'feast-dev/feast'
22+
github.event.pull_request.base.repo.full_name == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
1723
runs-on: ${{ matrix.os }}
1824
strategy:
1925
fail-fast: false

‎.github/workflows/smoke_tests.yml‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,14 @@ on:
44
pull_request:
55

66
jobs:
7+
check_skip_tests:
8+
uses: ./.github/workflows/check_skip_tests.yml
9+
with:
10+
head-sha: ${{ github.event.pull_request.head.sha }}
11+
excluded-dirs: 'docs/**,tests/**,examples/**'
12+
713
unit-test-python:
8-
if: ${{ !contains(github.event.pull_request.files, 'docs/') }} # Skip if docs files changed
14+
if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }}
915
runs-on: ${{ matrix.os }}
1016
strategy:
1117
fail-fast: false

0 commit comments

Comments
 (0)