Add init to Provider contract (#1796)

woop · web-flow · commit 7aad012bd95c · 2021-08-30T15:25:15.000-07:00
* Add init to provider

Signed-off-by: Willem Pienaar &lt;git@willem.co&gt;

* Update call site to not have repo_path

Signed-off-by: Willem Pienaar &lt;git@willem.co&gt;

* Add init to FooProvider

Signed-off-by: Willem Pienaar &lt;git@willem.co&gt;
diff --git a/sdk/python/feast/infra/provider.py b/sdk/python/feast/infra/provider.py
@@ -20,6 +20,10 @@
 
 
 class Provider(abc.ABC):
+    @abc.abstractmethod
+    def __init__(self, config: RepoConfig):
+        ...
+
     @abc.abstractmethod
     def update_infra(
         self,
@@ -161,7 +165,7 @@ def get_provider(config: RepoConfig, repo_path: Path) -> Provider:
 
         cls = importer.get_class_from_type(module_name, class_name, "Provider")
 
-        return cls(config, repo_path)
+        return cls(config)
 
 
 def _get_requested_feature_views_to_features_dict(
diff --git a/sdk/python/tests/foo_provider.py b/sdk/python/tests/foo_provider.py
@@ -13,6 +13,9 @@
 
 
 class FooProvider(Provider):
+    def __init__(self, config: RepoConfig):
+        pass
+
     def update_infra(
         self,
         project: str,
@@ -75,6 +78,3 @@ def online_read(
         requested_features: List[str] = None,
     ) -> List[Tuple[Optional[datetime], Optional[Dict[str, ValueProto]]]]:
         pass
-
-    def __init__(self, config, repo_path):
-        pass
