Skip to content

Commit 78cbd13

Browse files
terryyylimterryyylim
authored
Refactor configurable options and add sphinx docs (#1174)
* Refactor constants and add sphinx docs Signed-off-by: Terence <[email protected]> * Set default jobservice to none Signed-off-by: Terence <[email protected]> * Fix auth tests Signed-off-by: Terence <[email protected]> * Some fixes Signed-off-by: Terence <[email protected]> * Address comments Signed-off-by: Terence <[email protected]> * Address comments Signed-off-by: Terence <[email protected]> * Test none default Signed-off-by: Terence <[email protected]> * Set default as none Signed-off-by: Terence <[email protected]> * Update docs Signed-off-by: Terence <[email protected]> * Cleanup spark launcher constant Signed-off-by: Terence <[email protected]> * Update constants and clarify docstring Signed-off-by: Terence <[email protected]> * Polish docstrings Signed-off-by: Terence <[email protected]>
1 parent 3b5d30f commit 78cbd13

File tree

11 files changed

+326
-306
lines changed

11 files changed

+326
-306
lines changed

‎sdk/python/docs/index.rst‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,11 @@ Feature
3333

3434
.. automodule:: feast.feature
3535
:inherited-members:
36-
:members:
36+
:members:
37+
38+
Constants
39+
==================
40+
41+
.. automodule:: feast.constants
42+
:members:
43+
:exclude-members: AuthProvider, ConfigMeta

‎sdk/python/feast/cli.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
from feast.client import Client
2525
from feast.config import Config
26-
from feast.constants import CONFIG_SPARK_LAUNCHER
26+
from feast.constants import ConfigOptions as opt
2727
from feast.entity import Entity
2828
from feast.feature_table import FeatureTable
2929
from feast.job_service import start_job_service
@@ -422,7 +422,7 @@ def stop_stream_to_online(feature_table: str):
422422
Stop stream to online sync job
423423
"""
424424

425-
spark_launcher = Config().get(CONFIG_SPARK_LAUNCHER)
425+
spark_launcher = Config().get(opt.SPARK_LAUNCHER)
426426

427427
if spark_launcher == "emr":
428428
import feast.pyspark.aws.jobs
@@ -441,7 +441,7 @@ def list_jobs():
441441
"""
442442
from tabulate import tabulate
443443

444-
spark_launcher = Config().get(CONFIG_SPARK_LAUNCHER)
444+
spark_launcher = Config().get(opt.SPARK_LAUNCHER)
445445

446446
if spark_launcher == "emr":
447447
import feast.pyspark.aws.jobs

0 commit comments

Comments
 (0)