fix: Stop running go mod tidy in setup.py

achals · achals · commit 67164098d075 · 2022-06-28T11:37:03.000-07:00
Signed-off-by: Achal Shah <achals@gmail.com> This fixes a problem similar to pypa/cibuildwheel#189 (comment). Running `go mod tidy` was updating `go.mod` and `go.sum`, which was causeing cibuildwheel to produce dirty builds. This comamnd isn't really even needed, so nixing it.
diff --git a/setup.py b/setup.py
@@ -434,8 +434,6 @@ def build_extension(self, ext: Extension):
                               env={"PATH": bin_path, **go_env})
         subprocess.check_call(["go", "install", "github.com/go-python/gopy"],
                               env={"PATH": bin_path, **go_env})
-        subprocess.check_call(["go", "mod", "tidy"],
-                              env={"PATH": bin_path, **go_env})
         subprocess.check_call(
             [
                 "gopy",

Original file line number	Diff line number	Diff line change
`@@ -434,8 +434,6 @@ def build_extension(self, ext: Extension):`
`434`	`434`	`env={"PATH": bin_path, **go_env})`
`435`	`435`	`subprocess.check_call(["go", "install", "github.com/go-python/gopy"],`
`436`	`436`	`env={"PATH": bin_path, **go_env})`
`437`		`- subprocess.check_call(["go", "mod", "tidy"],`
`438`		`- env={"PATH": bin_path, **go_env})`
`439`	`437`	`subprocess.check_call(`
`440`	`438`	`[`
`441`	`439`	`"gopy",`