fix: Add description attribute to the from_proto method

gbmarc1 · adchia · commit 5cbfad05a286 · 2023-01-30T17:46:20.000-05:00
Signed-off-by: gbmarc1 &lt;marcantoine.belanger@shopify.com&gt;
diff --git a/sdk/python/feast/field.py b/sdk/python/feast/field.py
@@ -109,6 +109,7 @@ def from_proto(cls, field_proto: FieldProto):
             name=field_proto.name,
             dtype=from_value_type(value_type=value_type),
             tags=dict(field_proto.tags),
+            description=field_proto.description,
         )
 
     @classmethod
diff --git a/sdk/python/tests/unit/test_feature.py b/sdk/python/tests/unit/test_feature.py
@@ -27,3 +27,6 @@ def test_field_serialization_with_description():
 
     assert serialized_field.description == expected_description
     assert field_from_feature.description == expected_description
+
+    field = Field.from_proto(serialized_field)
+    assert field.description == expected_description 

Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,7 @@ def from_proto(cls, field_proto: FieldProto):`
`109`	`109`	`name=field_proto.name,`
`110`	`110`	`dtype=from_value_type(value_type=value_type),`
`111`	`111`	`tags=dict(field_proto.tags),`
	`112`	`+ description=field_proto.description,`
`112`	`113`	`)`
`113`	`114`
`114`	`115`	`@classmethod`