Skip to content

Commit 53aa4f7

Browse files
fix serialization
Signed-off-by: Miles Adkins <[email protected]>
1 parent 48ae284 commit 53aa4f7

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

sdk/python/feast/infra/online_stores/snowflake.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,11 @@ def online_write_batch(
9090

9191
for j, (feature_name, val) in enumerate(values.items()):
9292
df.loc[j, "entity_feature_key"] = serialize_entity_key(
93-
entity_key,
94-
entity_key_serialization_version=2
93+
entity_key, entity_key_serialization_version=2
9594
) + bytes(feature_name, encoding="utf-8")
96-
df.loc[j, "entity_key"] = serialize_entity_key(entity_key, entity_key_serialization_version=2)
95+
df.loc[j, "entity_key"] = serialize_entity_key(
96+
entity_key, entity_key_serialization_version=2
97+
)
9798
df.loc[j, "feature_name"] = feature_name
9899
df.loc[j, "value"] = val.SerializeToString()
99100
df.loc[j, "event_ts"] = timestamp
@@ -166,7 +167,9 @@ def online_read(
166167
)
167168

168169
for entity_key in entity_keys:
169-
entity_key_bin = serialize_entity_key(entity_key, entity_key_serialization_version=2)
170+
entity_key_bin = serialize_entity_key(
171+
entity_key, entity_key_serialization_version=2
172+
)
170173
res = {}
171174
res_ts = None
172175
for index, row in df[df["entity_key"] == entity_key_bin].iterrows():

sdk/python/feast/templates/snowflake/feature_store.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ offline_store:
99
role: SNOWFLAKE_ROLE
1010
warehouse: SNOWFLAKE_WAREHOUSE
1111
database: SNOWFLAKE_DATABASE
12-
entity_key_serialization_version: 2
1312
online_store:
1413
type: snowflake.online
1514
account: SNOWFLAKE_DEPLOYMENT_URL

0 commit comments

Comments
 (0)