fix: Add description attribute to the Field.from_proto method (#3469)

gbmarc1 · adchia · web-flow · commit 473f8d93fa8d · 2023-02-03T12:11:47.000-08:00
* fix: Add description attribute to the from_proto method

Signed-off-by: gbmarc1 &lt;marcantoine.belanger@shopify.com&gt;

* lint

Signed-off-by: Danny Chiao &lt;danny@tecton.ai&gt;

---------

Signed-off-by: gbmarc1 &lt;marcantoine.belanger@shopify.com&gt;
Signed-off-by: Danny Chiao &lt;danny@tecton.ai&gt;
Co-authored-by: Danny Chiao &lt;danny@tecton.ai&gt;
diff --git a/sdk/python/feast/field.py b/sdk/python/feast/field.py
@@ -109,6 +109,7 @@ def from_proto(cls, field_proto: FieldProto):
             name=field_proto.name,
             dtype=from_value_type(value_type=value_type),
             tags=dict(field_proto.tags),
+            description=field_proto.description,
         )
 
     @classmethod
diff --git a/sdk/python/tests/unit/test_feature.py b/sdk/python/tests/unit/test_feature.py
@@ -27,3 +27,6 @@ def test_field_serialization_with_description():
 
     assert serialized_field.description == expected_description
     assert field_from_feature.description == expected_description
+
+    field = Field.from_proto(serialized_field)
+    assert field.description == expected_description

Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,7 @@ def from_proto(cls, field_proto: FieldProto):`
`109`	`109`	`name=field_proto.name,`
`110`	`110`	`dtype=from_value_type(value_type=value_type),`
`111`	`111`	`tags=dict(field_proto.tags),`
	`112`	`+ description=field_proto.description,`
`112`	`113`	`)`
`113`	`114`
`114`	`115`	`@classmethod`