Skip to content

Commit 2a33f7b

Browse files
chesfeast-ci-bot
authored andcommitted
Publish datatypes/java along with sdk/java (#426)
This forward-ports a straggling commit from #407: it was missed when initially creating the datatypes module because Sonatype publishing setup was added concurrently.
1 parent 20ce16e commit 2a33f7b

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

.prow/scripts/publish-java-sdk.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,4 @@ gpg --import --batch --yes $GPG_KEY_IMPORT_DIR/private-key
6969
echo "============================================================"
7070
echo "Deploying Java SDK with revision: $REVISION"
7171
echo "============================================================"
72-
mvn --projects sdk/java -Drevision=$REVISION --batch-mode clean deploy
72+
mvn --projects datatypes/java,sdk/java -Drevision=$REVISION --batch-mode clean deploy

datatypes/java/README.md

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ Dependency Coordinates
2020
</dependency>
2121
```
2222

23+
Use the version corresponding to the Feast release you have deployed in your
24+
environment—see the [Feast release notes] for details.
25+
26+
[Feast release notes]: ../../CHANGELOG.md
27+
2328
Using the `.proto` Definitions
2429
------------------------------
2530

@@ -36,8 +41,15 @@ either for `include` or to compile with a different `protoc` plugin than Java.
3641
[Gradle]: https://github.com/google/protobuf-gradle-plugin#protos-in-dependencies
3742
[sbt-protoc]: https://github.com/thesamet/sbt-protoc
3843

39-
Publishing
40-
----------
44+
Releases
45+
--------
46+
47+
The module is published to Maven Central upon each release of Feast (since
48+
v0.3.7).
49+
50+
For developers, the publishing process is automated along with the Java SDK by
51+
[the `publish-java-sdk` build task in Prow][prow task], where you can see how
52+
it works. Artifacts are staged to Sonatype where a maintainer needs to take a
53+
release action for them to go live on Maven Central.
4154

42-
TODO: this module should be published to Maven Central upon Feast releases—this
43-
needs to be set up in POM configuration and release automation.
55+
[prow task]: https://github.com/gojek/feast/blob/17e7dca8238aae4dcbf0ff9f0db5d80ef8e035cf/.prow/config.yaml#L166-L192

0 commit comments

Comments
 (0)