accidentally removed entity from request

Ly Cao · Ly Cao · commit 2049f0af391b · 2022-02-18T22:31:24.000-05:00
diff --git a/go/feast/featurestore.go b/go/feast/featurestore.go
@@ -445,6 +445,9 @@ func (fs *FeatureStore) validateFeatureRefs(featureRefs []string, fullFeatureNam
 			collidedFeatureRefs[featureRef] += 1
 			if collidedFeatureRefs[featureRef] > 1 {
 				return errors.New(fmt.Sprintf("Collided FeatureRef detected: %s, %v", featureRef, featureRefs))
+				// return errors.New("To resolve this collision, please ensure that the feature views or their own features "+
+                // "have different names. If you're intentionally joining the same feature view twice on "+
+                // "different sets of entities, please rename one of the feature views with '.with_name'.")
 			}
 		}
 	} else {
@@ -465,6 +468,8 @@ func (fs *FeatureStore) validateFeatureRefs(featureRefs []string, fullFeatureNam
 
 			if collidedFeatureRefs[featureName] > 1 {
 				return errors.New(fmt.Sprintf("Collided FeatureName detected: %s, %v", featureName, featureRefs))
+				// return errors.New("To resolve this collision, either use the full feature name by setting "+
+                // "'full_feature_names=True', or ensure that the features in question have different names.")
 			}
 		}
 	}
diff --git a/sdk/python/feast/go_server.py b/sdk/python/feast/go_server.py
@@ -46,9 +46,9 @@ def get_online_features(
             errors.InvalidFeaturesParameterType(features)
 
         # print("GoServer get_online_features")
-        # for key, values in entities.items():
-        #     print(key)
-        #     request.entities[key].val.extend(python_values_to_proto_values(values))
+        for key, values in entities.items():
+            # print(key)
+            request.entities[key].val.extend(python_values_to_proto_values(values))
         # print("==============")
         
         try:

Original file line number	Diff line number	Diff line change
`@@ -445,6 +445,9 @@ func (fs *FeatureStore) validateFeatureRefs(featureRefs []string, fullFeatureNam`
`445`	`445`	`collidedFeatureRefs[featureRef] += 1`
`446`	`446`	`if collidedFeatureRefs[featureRef] > 1 {`
`447`	`447`	`return errors.New(fmt.Sprintf("Collided FeatureRef detected: %s, %v", featureRef, featureRefs))`
	`448`	`+ // return errors.New("To resolve this collision, please ensure that the feature views or their own features "+`
	`449`	`+ // "have different names. If you're intentionally joining the same feature view twice on "+`
	`450`	`+ // "different sets of entities, please rename one of the feature views with '.with_name'.")`
`448`	`451`	`}`
`449`	`452`	`}`
`450`	`453`	`} else {`
`@@ -465,6 +468,8 @@ func (fs *FeatureStore) validateFeatureRefs(featureRefs []string, fullFeatureNam`
`465`	`468`
`466`	`469`	`if collidedFeatureRefs[featureName] > 1 {`
`467`	`470`	`return errors.New(fmt.Sprintf("Collided FeatureName detected: %s, %v", featureName, featureRefs))`
	`471`	`+ // return errors.New("To resolve this collision, either use the full feature name by setting "+`
	`472`	`+ // "'full_feature_names=True', or ensure that the features in question have different names.")`
`468`	`473`	`}`
`469`	`474`	`}`
`470`	`475`	`}`