Fix linting #58
Merged
Fix linting #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkgl0w
approved these changes
Jan 11, 2022
Member
darkgl0w
left a comment
darkgl0w
left a comment
There was a problem hiding this comment.
There's a few nits but overall LGTM with the changes I have suggested.
0xvbetsun
force-pushed
the
fix-linting
branch
from
c12f6b8 to
811094c
Compare
Eomm
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56
Also, the
taplibrary was increased to the 15th version, and tests were actualized regarding this version.Fixed minor typo in the readme
Checklist
npm run testandnpm run benchmarkand the Code of conduct