-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Should testing style be changed? #5959
Copy link
Copy link
Open
Labels
discussionIssues or PRs with this label will never staleIssues or PRs with this label will never staleinternalsChange that won't impact the surface API.Change that won't impact the surface API.testIssue or pr related to our testing infrastructure.Issue or pr related to our testing infrastructure.
Metadata
Metadata
Assignees
Labels
discussionIssues or PRs with this label will never staleIssues or PRs with this label will never staleinternalsChange that won't impact the surface API.Change that won't impact the surface API.testIssue or pr related to our testing infrastructure.Issue or pr related to our testing infrastructure.
PR #5953 proposes changing our test suites to use
const { describe, test } = require('node:test')instead ofconst test = require('node:test'). This seems to have come about through various mentions of the style across a few PRs that contribute to moving us fromtaptonode:test. As I noted in that PR, PRs are not always reviewed by the whole team and that for such changes we should really have a discussion first to reach a consensus. Thus, I am opening this issue.@fastify/leads @fastify/core: what are your thoughts on this issue?
Personally, I am not for the change due to:
describestyle.describestyle too verbose. I prefer simple tests with a clear title/description.