Discard default lifespans before merging#15424
Open
alfred82santa wants to merge 5 commits into
Open
Conversation
Author
|
@YuriiMotov can you check it? or do you prefer I close it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves performance of lifespan contexts. Currently routers inject a default lifespan when no one is provided. The issue is when a router is included to other router, the lifespans (base and child routers' lifespans) must be merged, even when they are no-op default lifespans. This PR checks if base router or child router use a default lifespan to decide if they must be merged.
On the other hand, it changes the way to merge async context manager with a more pythonic way.