Skip to content

feat: add tls and api key authentication support #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vieiralucas merged 7 commits into from
Mar 21, 2026
Merged

feat: add tls and api key authentication support #1

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8669f96
feat: add tls and api key authentication support
vieiralucas Mar 21, 2026
263f968
fix: address cubic review findings for tls/auth support
vieiralucas Mar 21, 2026
1143d0e
fix: apply spotless formatting
vieiralucas Mar 21, 2026
87bd3b0
fix: revert path-based binary check to preserve tls test skip behavio…
vieiralucas Mar 21, 2026
ee286e7
fix: address remaining cubic review findings
vieiralucas Mar 21, 2026
8bd03bb
feat: add system trust store support via withTls()
vieiralucas Mar 21, 2026
82eef1c
fix: keep FilaException for client cert validation error
vieiralucas Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: revert path-based binary check to preserve tls test skip behavio… 
…r in ci
  • Loading branch information
@vieiralucas
vieiralucas committed Mar 21, 2026
commit 87bd3b0af253e73e37dd04bd73128bbcf5ee4cfc
20 changes: 9 additions & 11 deletions src/test/java/dev/faisca/fila/TestServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,20 +108,18 @@ void stop() {
deleteDirectory(dataDir);
}

/** Returns true if the fila-server binary is available. */
/**
* Returns true if the fila-server binary is available at a known local path.
*
* <p>Note: This intentionally does NOT check PATH. The TLS integration tests require a local dev
* build to ensure cert generation and server config are compatible. In CI, the plaintext
* integration tests run via {@link FilaClientTest} using the downloaded binary; the TLS tests are
* skipped until the CI pipeline is configured to provision TLS test infrastructure.
*/
static boolean isBinaryAvailable() {
try {
String path = findBinary();
if (path == null) return false;
// If it's a local path, check executability directly
Path p = Path.of(path);
if (p.isAbsolute() || path.contains("/") || path.contains("\\")) {
return Files.isExecutable(p);
}
// For bare command names (on PATH), probe with "which"
Process probe = new ProcessBuilder("which", path).redirectErrorStream(true).start();
int exit = probe.waitFor();
return exit == 0;
return path != null && Files.isExecutable(Path.of(path));
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
} catch (Exception e) {
return false;
}
Expand Down
Loading