Merge pull request #1 from cmaddalozzo/feature/stderr-buffer-size-config

cmaddalozzo · web-flow · commit 8a7f97b9684b · 2017-07-25T17:07:25.000+01:00
Truncate the size of stderr buffer according to config
diff --git a/index.js b/index.js
@@ -53,6 +53,7 @@ var PythonShell = function (script, options) {
     this.script = path.join(options.scriptPath || './', script);
     this.command = pythonOptions.concat(this.script, scriptArgs);
     this.mode = options.mode || 'text';
+    this.stdErrMaxBufferSize = options.stdErrMaxBufferSize || Infinity;
     this.formatter = resolve('format', options.formatter || this.mode);
     this.parser = resolve('parse', options.parser || this.mode);
     this.terminated = false;
@@ -70,7 +71,11 @@ var PythonShell = function (script, options) {
 
     // listen to stderr and emit errors for incoming data
     this.stderr.on('data', function (data) {
-        errorData += ''+data;
+        var tmp = errorData + data;
+        if (tmp.length >= self.stdErrMaxBufferSize) {
+          tmp = tmp.substring(tmp.length - self.stdErrMaxBufferSize, tmp.length);
+        }
+        errorData = tmp;
     });
 
     this.stderr.on('end', function(){
diff --git a/test/test-python-shell.js b/test/test-python-shell.js
@@ -265,6 +265,13 @@ describe('PythonShell', function () {
                 done();
             });
         });
+        it('should truncate stderr when it\'s longer than stdErrMaxBufferSize', function (done) {
+            var pyshell = new PythonShell('error.py', { stdErrMaxBufferSize: 128 });
+            pyshell.on('error', function (err) {
+                err.message.should.have.lengthOf(128);
+                done();
+            });
+        });
     });
 
     describe('.parseError(data)', function () {
