Closed
Conversation
Contributor
|
Thanks, but please rename/squash your commit: https://github.com/exercism/python#pull-requests |
| @@ -1,2 +1,2 @@ | |||
| def collatz_steps(): | |||
| def collatz_steps(integerToTest): | |||
Contributor
There was a problem hiding this comment.
Python favors snake_case over CamelCase.
A good Python style guide from Google - https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry I wrote a terrible commit message for these, I will follow the proper form exercise-name: Changes some things next time. I will just leave that info here for now.
collatz_steps: added parameter integerToTest
word_count: added parameter stringToCount
fixes #552
fixes #652