Skip to content

Fix issue #1261 WorkbookWriter sheet.protect() function doesn't exist #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alubbe merged 9 commits into from
Sep 28, 2020
Merged

Fix issue #1261 WorkbookWriter sheet.protect() function doesn't exist #1262

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b3ef29b
copying protect method from worksheet.js
May 8, 2020
65e54c2
copying protect method from worksheet.js
May 8, 2020
2c7cd20
moving test into pr spec file
May 8, 2020
d694cf8
renaming file
May 8, 2020
e36637a
added worksheet protection variable initialization to constructor
May 11, 2020
a6c1821
Merge branch 'master' of github.com:exceljs/exceljs
May 20, 2020
7732d11
Merge branch 'master' of github.com:exceljs/exceljs
May 22, 2020
913d0b5
Merge branch 'master' of github.com:exceljs/exceljs
Aug 18, 2020
fb59f28
updated test to read in file and ensure sheet protection is still there.
Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added worksheet protection variable initialization to constructor
  • Loading branch information
Reza Heidari committed May 11, 2020
commit e36637a87c277b5ff71baf30b53a3cc63a12e81d
4 changes: 3 additions & 1 deletion lib/stream/xlsx/worksheet-writer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ class WorksheetWriter {

this._media = [];

// worksheet protection
this.sheetProtection = null;

// start writing to stream now
this._writeOpenWorksheet();

Expand Down Expand Up @@ -429,7 +432,6 @@ class WorksheetWriter {
}

removeConditionalFormatting(filter) {
console.log('conditionalFormatting', this.conditionalFormatting);
if (typeof filter === 'number') {
this.conditionalFormatting.splice(filter, 1);
} else if (filter instanceof Function) {
Expand Down