Skip to content

Remaining Zeitwerk fixes #6781

Description

@headius

In #5638 we were tracking our pass rate on the Zeitwerk test suite, which required the load service work from #5764. Most of that suite is now passing, with the following three tests the only failures:

Failure:
TestRubyCompatibility#test_absolute_paths_passed_to_require_end_up_in__LOADED_FEATURES_as_is [/Users/headius/projects/zeitwerk/test/lib/zeitwerk/test_ruby_compatibility.rb:50]
Minitest::Assertion: Expected false to be truthy.

Error:
TestExplicitNamespace#test_explicit_namespaces_enable_the_tracer_until_loaded:
NameError: uninitialized constant TestExplicitNamespace::Hotel
    org/jruby/RubyModule.java:3942:in `const_missing'
    /Users/headius/projects/zeitwerk/test/lib/zeitwerk/test_explicit_namespace.rb:155:in `block in test_explicit_namespaces_enable_the_tracer_until_loaded'
    /Users/headius/projects/zeitwerk/test/support/loader_test.rb:82:in `block in with_setup'
    /Users/headius/projects/zeitwerk/test/support/loader_test.rb:61:in `block in with_files'
    org/jruby/RubyDir.java:419:in `chdir'
    /Users/headius/projects/zeitwerk/test/support/loader_test.rb:54:in `with_files'
    /Users/headius/projects/zeitwerk/test/support/loader_test.rb:76:in `with_setup'
    /Users/headius/projects/zeitwerk/test/lib/zeitwerk/test_explicit_namespace.rb:153:in `block in test_explicit_namespaces_enable_the_tracer_until_loaded'

Error:
TestExplicitNamespace#test_the_tracer_handles_singleton_classes:
NameError: uninitialized constant TestExplicitNamespace::Hotel
    org/jruby/RubyModule.java:3942:in `const_missing'
    /Users/headius/projects/zeitwerk/test/lib/zeitwerk/test_explicit_namespace.rb:200:in `block in test_the_tracer_handles_singleton_classes'
    /Users/headius/projects/zeitwerk/test/support/loader_test.rb:82:in `block in with_setup'
    /Users/headius/projects/zeitwerk/test/support/loader_test.rb:61:in `block in with_files'
    org/jruby/RubyDir.java:419:in `chdir'
    /Users/headius/projects/zeitwerk/test/support/loader_test.rb:54:in `with_files'
    /Users/headius/projects/zeitwerk/test/support/loader_test.rb:76:in `with_setup'
    /Users/headius/projects/zeitwerk/test/lib/zeitwerk/test_explicit_namespace.rb:198:in `block in test_the_tracer_handles_singleton_classes'

I'm moving these last three to a separate issue for 9.3.1.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions