BAEL-2076: loading resources#7347
Merged
ashleyfrieze merged 5 commits intomasterfrom Sep 5, 2019
unknown repository
Merged
Conversation
ghost
commented
Jul 18, 2019
ghost
commented
- Created core-java-io2 module
- added resource loading example code
- added core-java-io2 to tutorials pom.xml
- Created core-java-io2 module - added resource loading example code - added core-java-io2 to tutorials pom.xml
ashleyfrieze
reviewed
Aug 1, 2019
ashleyfrieze
reviewed
Aug 1, 2019
ashleyfrieze
reviewed
Aug 1, 2019
- change to try-with-resources - change the order of main method
ashleyfrieze
reviewed
Aug 6, 2019
|
|
||
| private void loadFileWithReader() throws IOException { | ||
|
|
||
| try (FileReader fileReader = new FileReader("src/main/resources/input.txt"); BufferedReader reader = new BufferedReader(fileReader)) { |
Contributor
There was a problem hiding this comment.
It would probably help if you put a linebreak after the ; here
|
|
||
| private void loadFileAsResource() throws IOException { | ||
|
|
||
| try (InputStream inputStream = getClass().getResourceAsStream("/input.txt"); BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream))) { |
Contributor
There was a problem hiding this comment.
another ; / linebreak combo here too please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.