Skip to content

ENG-2806: Migrate IDP staged resources to unified IDP_APP type#7712

Draft
dsill-ethyca wants to merge 4 commits intomainfrom
ENG-2806-idp-migration
Draft

ENG-2806: Migrate IDP staged resources to unified IDP_APP type#7712
dsill-ethyca wants to merge 4 commits intomainfrom
ENG-2806-idp-migration

Conversation

@dsill-ethyca
Copy link
Contributor

@dsill-ethyca dsill-ethyca commented Mar 20, 2026

Ticket ENG-2806

Description Of Changes

Add a data migration to unify IDP staged resource types. Existing Okta App and Entra App rows are consolidated to a single IDP App resource type, with the provider stored in meta["provider"]. Also renames the legacy okta_app_id key to the generic app_id in the meta JSON.

Dependency: Fidesplus PR ethyca/fidesplus#3267 consumes the new IDP App resource type. This migration should be merged first.

No customer data is affected — IDP monitor resources are not yet in production. This migration keeps continuity in dev/staging environments.

Code Changes

  • src/fides/api/alembic/migrations/versions/xx_2026_03_20_1745_ad1bb600715b_migrate_idp_staged_resources.py - Data migration: rename okta_app_idapp_id in meta, add provider key, update resource_type from Okta App/Entra App to IDP App

Steps to Confirm

  1. Run alembic upgrade head — verify migration applies without errors
  2. Query SELECT resource_type, meta->>'provider', meta->>'app_id' FROM stagedresource WHERE resource_type = 'IDP App' — verify all IDP resources have the new type and provider
  3. Run alembic downgrade 38071fffda39 — verify downgrade restores original Okta App/Entra App types and okta_app_id key

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Mar 20, 2026 6:18pm
fides-privacy-center Ignored Ignored Mar 20, 2026 6:18pm

Request Review

Migrates existing Okta App/Entra App staged resources to unified IDP App
resource type with provider stored in meta JSON.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@dsill-ethyca dsill-ethyca force-pushed the ENG-2806-idp-migration branch from 8ae7791 to 8500b2f Compare March 20, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants