ENG-3028: Fix GPC title and description showing i18n keys instead of default values in the Privacy Center consent page (gpc.title and gpc.description)#7710
Open
nreyes-dev wants to merge 11 commits intomainfrom
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3028
Description Of Changes
The GPC (Global Privacy Control) banner in the Privacy Center displayed raw i18n keys (
exp.gpc_title,exp.gpc_description) instead of the actual translated text. This happened because the API returnsnullfor GPC translation fields on newly created experiences, and there was no fallback to the bundled static defaults.Code Changes
clients/privacy-center/components/ConsentPage.tsx— In config-driven consent mode, map static GPC messages (static.gpc.*) toexp.*keys so the GPC banner can find them.clients/fides-js/src/lib/i18n/i18n-utils.ts— In notice-driven consent mode, fall back to static GPC messages when the API returns null for GPC translation fields.Steps to Confirm
?geolocation=US-CA&globalPrivacyControl=truePre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works