Eng 567 pr3 version history surfaces#7689
Draft
Vagoasdf wants to merge 17 commits intoENG-567_pr2-saas-config-versionfrom
Draft
Eng 567 pr3 version history surfaces#7689Vagoasdf wants to merge 17 commits intoENG-567_pr2-saas-config-versionfrom
Vagoasdf wants to merge 17 commits intoENG-567_pr2-saas-config-versionfrom
Conversation
This will save a snapshot of the connection config history th check during runtime
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Vagoasdf
force-pushed
the
ENG-567_pr2-saas-config-version
branch
2 times, most recently
from
b3ebb01 to
0d2296b
Compare
connectorType was derived from the RTK Query result, which returns undefined once pending is cleared (skip: true). The modal condition active && connectorType would always be falsy, so the modal never opened in production. Store connectorType directly in active state so the modal renders independently of the skipped query.
…ig type If openVersionModal was called with a non-SaaS connection key, the effect condition never fired and pending stayed set indefinitely, keeping the hook subscribed to that connection key. Now pending is always cleared once connection resolves, regardless of whether a connectorType was found.
The clickable version badge was using a <span> with onClick, requiring two jsx-a11y eslint-disable comments. Replace with a <button> when connectionKey is present (keyboard-accessible, correct semantics) and a plain <span> when no connectionKey is given (non-interactive).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket []
Description Of Changes
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works