clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InfrastructureSystemActionsCell.tsx (2)

186-190: Dead code: button text will never render.

Since approveIcon has a default value (<Icons.Checkmark />), the condition !approveIcon && "Approve" will always be falsy and the text "Approve" will never be displayed. If the icon-only button is intentional, consider removing the dead code. If text should sometimes appear, remove the default value or change the condition.

🧹 Remove dead code

          icon={approveIcon}
          aria-label="Approve"
-        >
-          {!approveIcon && "Approve"}
-        </Button>
+        />

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InfrastructureSystemActionsCell.tsx`
around lines 186 - 190, The JSX contains dead code: the Button child
{!approveIcon && "Approve"} will never render because approveIcon has a default
(Icons.Checkmark). Update InfrastructureSystemActionsCell to either remove the
dead branch or make text conditional correctly: either delete the noop
expression and keep the icon-only Button (remove {!approveIcon && "Approve"}),
or change the prop/default so approveIcon can be undefined when you want text
(remove the default value for approveIcon) and keep the conditional; locate the
Button usage and the approveIcon default to apply the chosen fix.

---

135-137: Minor text inconsistency.

The tooltip says "Restore systems before adding to the inventory" but the action is now labeled "Approve". Consider updating for consistency.

📝 Suggested fix

     if (isApprove && isIgnored) {
-      return "Restore systems before adding to the inventory";
+      return "Restore systems before approving";
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InfrastructureSystemActionsCell.tsx`
around lines 135 - 137, Tooltip text in InfrastructureSystemActionsCell is
inconsistent with the "Approve" action; update the string returned in the
isApprove && isIgnored branch to match the action label (e.g., change "Restore
systems before adding to the inventory" to "Approve systems before adding to the
inventory") so the tooltip reflects the "Approve" action; locate the conditional
in InfrastructureSystemActionsCell that checks isApprove and isIgnored and
replace the message accordingly.

changelog/7596.yaml (1)

1-4: Consider a more descriptive changelog entry.

The description "Okta ux refactor" is quite generic. A clearer entry would help users understand what changed, e.g., "Changed 'Add' action labels to 'Approve' for infrastructure monitors and added informational banner."

📝 Suggested improvement

 type: Changed # One of: Added, Changed, Developer Experience, Deprecated, Docs, Fixed, Removed, Security
-description: Okta ux refactor
+description: Updated infrastructure monitor action labels from "Add" to "Approve" and added dismissible informational banner
 pr: 7596 # PR number
 labels: [] # Optional: ["high-risk", "db-migration"]

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@changelog/7596.yaml` around lines 1 - 4, Update the changelog entry's
description field to be more specific and user-facing: replace the generic "Okta
ux refactor" with a concise summary of the user-visible changes (for example,
"Changed 'Add' action labels to 'Approve' for infrastructure monitors and added
an informational banner about Okta sign-in changes") and keep the pr: 7596 and
other metadata intact; ensure the new description accurately reflects the UX
changes implemented and is brief but descriptive.