Reviewer's Guide

Refactors several GraphQL product query resolvers to satisfy Sonar suggestions by simplifying numeric vs string meta handling, using safer/more explicit RegExp construction and modern array helpers, and removing unreachable returns in bridge resolvers.

File-Level Changes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

DeepSource Code Review

We reviewed changes in 11ffffb...7bedefd on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade

Security   Reliability   Complexity   Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
JavaScript		Mar 19, 2026 9:23a.m.	Review ↗
Docker		Mar 19, 2026 9:23a.m.	Review ↗

🌗 Pull Request Overview

This PR addresses SonarQube code quality issues in GraphQL resolver query files. The changes include removing unnecessary return statements, replacing replace() with replaceAll() for correct multi-occurrence replacements, inverting isNaN conditionals for clarity, and using some() instead of find() for boolean checks.

Reviewed Changes
Kimi performed full review on 3 changed files and found 1 issue.

📋 Review Findings

📄 backend/plugins/posclient_api/src/modules/posclient/graphql/resolvers/queries/cpProducts.ts

🟡 MEDIUM code-quality: Potential behavioral change with replaceAll() for regex special characters

Line 188

The change from replace(/_/g, '.') to replaceAll('_', '.') is correct (both replace all occurrences). However, there's a logic issue: both * and _ are being replaced with . (match any character). If a user provides a search string with both characters, they both become . which may not be the intended behavior for _ (typically a single character wildcard, not any number).

💡 Suggested fix:

Consider using different regex patterns for * (zero or more) vs _ (single character):

// Current code (both become '.' which matches any single character):
const codeRegex = new RegExp(
  `^${searchValue.replaceAll('*', '.*').replaceAll('_', '.')}$`,
  'igu',
);

📄 backend/plugins/posclient_api/src/modules/posclient/graphql/resolvers/queries/products.ts

🟡 MEDIUM code-quality: Same regex pattern issue as cpProducts.ts

Line 165

Same concern as above - the pattern replacement for * and _ both use . which only matches a single character. * typically means "zero or more of preceding" in wildcards.

💡 Suggested fix:

const codeRegex = new RegExp(
  `^${searchValue.replaceAll('*', '.*').replaceAll('_', '.')}$`,
  'igu',
);

📄 backend/plugins/posclient_api/src/modules/posclient/graphql/resolvers/queries/bridges.ts

✅ No issues found. The removal of unnecessary return; statements at the end of async functions is correct. These functions return Promise<void> implicitly, and the explicit return; statements were redundant.

📄 backend/plugins/posclient_api/src/modules/posclient/graphql/resolvers/queries/cpProducts.ts (continued)

🔵 LOW nitpick: Inconsistent Number.isNaN() check between generateFilter and generateFilterCat

Lines 238, 342

In generateFilter, the check is Number.isNaN(Number(categoryMeta)) (converts to Number first), but in generateFilterCat, it's Number.isNaN(meta) directly. If meta is passed as a string like "123", these behave differently. Ensure consistent validation across both functions.

✅ Overall Assessment

The PR makes legitimate code quality improvements:

• ✅ Removing unnecessary return statements improves readability
• ✅ Using replaceAll() fixes potential bugs where only first occurrence was replaced
• ✅ Using some() instead of find() is semantically clearer for boolean checks
• ✅ The String.raw usage for regex escaping is cleaner

Recommendation: Address the wildcard regex pattern issue (using .* for * instead of .) to ensure the search behaves as users would expect from standard wildcard patterns.

_{Powered by Kimi | Model: kimi-k2.5}

Quality Gate failed

Failed conditions
100.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud