Skip to content

fix: nacos error user not found when create tenant #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CeerDecy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: nacos error user not found when create tenant #6673

CeerDecy wants to merge 2 commits into from

Conversation

@CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Dec 30, 2025 •
edited
Loading

What this PR does / why we need it:

fix: nacos error user not found when create tenant

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx @sfwn

ChangeLog

Language Changelog
🇺🇸 English fix: nacos error user not found when create tenant
🇨🇳 中文 修复nacos创建租户时报错 user not found

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested review from iutx and sfwn December 30, 2025 07:05
iutx
iutx previously approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/approve

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.93%. Comparing base (8a3406d) to head (deb6874).

Files with missing lines Patch % Lines
internal/apps/msp/resource/utils/nacos_client.go 37.50% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6673      +/-   ##
==========================================
- Coverage   14.93%   14.93%   -0.01%     
==========================================
  Files        3934     3934              
  Lines      323932   323925       -7     
==========================================
- Hits        48385    48380       -5     
  Misses     270030   270030              
+ Partials     5517     5515       -2
Flag Coverage Δ
by-github-actions 14.93% <37.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/apps/msp/resource/utils/nacos_client.go 48.97% <37.50%> (+3.26%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iutx iutx iutx left review comments

@sfwn sfwn Awaiting requested review from sfwn

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bugfix

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CeerDecy @iutx @erda-bot