Skip to content

Commit df24144

Browse files
committed
Fix ticket danmar#437 (Compile warnings in GUI (in Linux))
https://sourceforge.net/apps/trac/cppcheck/ticket/437 Add empty cases for XML element types we don't need to handle.
1 parent 85f8ba7 commit df24144

File tree

1 file changed

+28
-1
lines changed

1 file changed

+28
-1
lines changed

gui/projectfile.cpp

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ bool ProjectFile::Read(const QString &filename)
5656
case QXmlStreamReader::StartElement:
5757
if (xmlReader.name() == ProjectElementName)
5858
insideProject = true;
59+
60+
// Find allocelement from inside project element
5961
if (insideProject && xmlReader.name() == AllocElementName)
6062
ReadAutoAllocClasses(xmlReader);
6163
break;
@@ -64,6 +66,18 @@ bool ProjectFile::Read(const QString &filename)
6466
if (xmlReader.name() == ProjectElementName)
6567
insideProject = false;
6668
break;
69+
70+
// Not handled
71+
case QXmlStreamReader::NoToken:
72+
case QXmlStreamReader::Invalid:
73+
case QXmlStreamReader::StartDocument:
74+
case QXmlStreamReader::EndDocument:
75+
case QXmlStreamReader::Characters:
76+
case QXmlStreamReader::Comment:
77+
case QXmlStreamReader::DTD:
78+
case QXmlStreamReader::EntityReference:
79+
case QXmlStreamReader::ProcessingInstruction:
80+
break;
6781
}
6882
}
6983

@@ -86,6 +100,8 @@ void ProjectFile::ReadAutoAllocClasses(QXmlStreamReader &reader)
86100
switch (type)
87101
{
88102
case QXmlStreamReader::StartElement:
103+
104+
// Read class-elements
89105
if (reader.name().toString() == ClassElementName)
90106
{
91107
QXmlStreamAttributes attribs = reader.attributes();
@@ -99,8 +115,19 @@ void ProjectFile::ReadAutoAllocClasses(QXmlStreamReader &reader)
99115
if (reader.name().toString() == AllocElementName)
100116
allRead = true;
101117
break;
102-
}
103118

119+
// Not handled
120+
case QXmlStreamReader::NoToken:
121+
case QXmlStreamReader::Invalid:
122+
case QXmlStreamReader::StartDocument:
123+
case QXmlStreamReader::EndDocument:
124+
case QXmlStreamReader::Characters:
125+
case QXmlStreamReader::Comment:
126+
case QXmlStreamReader::DTD:
127+
case QXmlStreamReader::EntityReference:
128+
case QXmlStreamReader::ProcessingInstruction:
129+
break;
130+
}
104131
}
105132
while (!allRead);
106133
}

0 commit comments

Comments
 (0)