refactoring: loop through all Check instances and execute the runChecks function

Daniel Marjam&auml;ki · Daniel Marjam&auml;ki · commit 16b6a7a60548 · 2009-03-19T19:24:13.000+01:00
diff --git a/cppcheck.cbp b/cppcheck.cbp
@@ -43,6 +43,7 @@
 		<Unit filename="gui/resultsview.h" />
 		<Unit filename="gui/settingsdialog.cpp" />
 		<Unit filename="gui/settingsdialog.h" />
+		<Unit filename="src/check.h" />
 		<Unit filename="src/checkbufferoverrun.cpp" />
 		<Unit filename="src/checkbufferoverrun.h" />
 		<Unit filename="src/checkclass.cpp" />
diff --git a/src/check.h b/src/check.h
@@ -21,28 +21,34 @@
 #define checkH
 
 #include "settings.h"
+#include <list>
 
 class Tokenizer;
 class ErrorLogger;
 
 class Check
 {
 public:
-
-    Check(const Tokenizer * const tokenizer, const Settings &settings, ErrorLogger *errorLogger)
-            : _tokenizer(tokenizer), _settings(settings), _errorLogger(errorLogger)
-    { }
+    // This constructor is used when registering the CheckClass
+    Check()
+    {
+        instances().push_back(this);
+    }
 
     virtual ~Check()
-    { }
+    {
+        instances().remove(this);
+    }
 
-    /** run checks.. */
-    virtual void runChecks() = 0;
+    /** get instances of this */
+    static std::list<Check *> &instances()
+    {
+        static std::list<Check *> _instances;
+        return _instances;
+    }
 
-protected:
-    const Tokenizer * const _tokenizer;
-    const Settings &_settings;
-    ErrorLogger *_errorLogger;
+    /** run checks.. */
+    virtual void runChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger) = 0;
 };
 
 #endif
diff --git a/src/checkstl.cpp b/src/checkstl.cpp
@@ -22,6 +22,10 @@
 #include "token.h"
 
 
+// Create a static instance of this
+static CheckStl instance;
+
+
 void CheckStl::iterators()
 {
     for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next())
diff --git a/src/checkstl.h b/src/checkstl.h
@@ -31,14 +31,12 @@ class CheckStl : public Check
 {
 public:
 
-    CheckStl(const Tokenizer * const tokenizer, const Settings &settings, ErrorLogger *errorLogger)
-            : Check(tokenizer, settings, errorLogger)
+    void runChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
     {
+        _tokenizer = tokenizer;
+        _settings = settings;
+        _errorLogger = errorLogger;
 
-    }
-
-    void runChecks()
-    {
         stlOutOfBounds();
         iterators();
         erase();
@@ -76,6 +74,10 @@ class CheckStl : public Check
      * @param it iterator token
      */
     void eraseCheckLoop(const Token *it);
+
+    const Tokenizer *_tokenizer;
+    const Settings *_settings;
+    ErrorLogger *_errorLogger;
 };
 
 //---------------------------------------------------------------------------
diff --git a/src/cppcheck.cpp b/src/cppcheck.cpp
@@ -30,6 +30,8 @@
 #include "checkfunctionusage.h"
 #include "filelister.h"
 
+#include "check.h"
+
 #include <algorithm>
 #include <iostream>
 #include <sstream>
@@ -481,6 +483,11 @@ void CppCheck::checkFile(const std::string &code, const char FileName[])
     // Unusual pointer arithmetic
     if (ErrorLogger::strPlusChar())
         checkOther.strPlusChar();
+
+    for (std::list<Check *>::iterator it = Check::instances().begin(); it != Check::instances().end(); ++it)
+    {
+        (*it)->runChecks(&_tokenizer, &_settings, this);
+    }
 }
 
 Settings CppCheck::settings() const

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,10 @@`
`22`	`22`	`#include "token.h"`
`23`	`23`
`24`	`24`
	`25`	`+// Create a static instance of this`
	`26`	`+static CheckStl instance;`
	`27`	`+`
	`28`	`+`
`25`	`29`	`void CheckStl::iterators()`
`26`	`30`	`{`
`27`	`31`	`for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next())`