fix(expert): save new configuration after workspace/didChangeConfiguration
#282
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation State handler of workspace/didChangeConfiguration message was always returning old configuration, so the changes to dialyzer support were not preserved.
Member
|
Can you clarify what you are seeing a bit more? We don't support dialyzer at all nor a projectDir configuration option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State handler of workspace/didChangeConfiguration message was always returning old configuration, so the changes to dialyzer support were not preserved.
This is maybe not super important, as the dialyzer config does not seem to be used anywhere, but it gets the general
didChangeConfigurationflow right for the future - and I would like to addprojectDirchange handled bydidChangeConfiguration, as this is default way to tweak the setting per-project in Emacs.