fix(engine): code lens exception when mix.exs not found #281
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens when the project is opened where a Mix project is not in
the root directory, but in a subdirectory. Expert can still resolve some
things, some don't work, but when it comes to code lens, it just throws
exception.
{"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"** (FunctionClauseError) no function clause matching in IO.chardata_to_string/1\n (elixir 1.19.4) lib/io.ex:738: IO.chardata_to_string(nil)\n (elixir 1.19.4) lib/path.ex:835: Path.expand_home/1\n (elixir 1.19.4) lib/path.ex:195: Path.expand/1\n (xp_expert 0.1.0) lib/expert/provider/handlers/code_lens.ex:65: XPExpert.Provider.Handlers.CodeLens.normalize_path/1\n (xp_expert 0.1.0) lib/expert/provider/handlers/code_lens.ex:57: XPExpert.Provider.Handlers.CodeLens.show_reindex_lens?/2\n (xp_expert 0.1.0) lib/expert/provider/handlers/code_lens.ex:31: XPExpert.Provider.Handlers.CodeLens.reindex_lens/2\n (xp_expert 0.1.0) lib/expert/provider/handlers/code_lens.ex:22: XPExpert.Provider.Handlers.CodeLens.handle/2\n (xp_expert 0.1.0) lib/expert.ex:115: XPExpert.handle_request/2\n","type":1}}
Given that Project.mix_exs_path can explicitly (based on a
type spec) return nil, so this situation should be handled gracefully.
katafrakt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens to me when the project is opened where a Mix project is not in the root directory, but in a subdirectory (i.e. a typocal monorepo setting). Expert can still resolve some things (go to definition), some don't work (hover docs), but when it comes to code lens, it just throws an exception.
Given that
Project.mix_exs_pathcan explicitly (based on a type spec) returnnil, this situation should be handled gracefully and the function should returnfalse, not result in an exception.