TranslationHandler now suggests a language based on sysytem locale.

vesap · vesap · commit 7a4115236aa6 · 2009-07-02T23:41:37.000+03:00
Also made sure toolbar visibility is updated before saving settings.
diff --git a/gui/mainwindow.cpp b/gui/mainwindow.cpp
@@ -167,11 +167,14 @@ void MainWindow::LoadSettings()
 
     QString error = "";
 
-    SetLanguage(mSettings->value(SETTINGS_LANGUAGE, 0).toInt());
+    SetLanguage(mSettings->value(SETTINGS_LANGUAGE, mTranslation->SuggestLanguage()).toInt());
 }
 
 void MainWindow::SaveSettings()
 {
+    //Force toolbar checkbox value to be updated
+    AboutToShowViewMenu();
+
     mSettings->setValue(SETTINGS_WINDOW_WIDTH, size().width());
     mSettings->setValue(SETTINGS_WINDOW_HEIGHT, size().height());
     mSettings->setValue(SETTINGS_WINDOW_MAXIMIZED, isMaximized());
diff --git a/gui/translationhandler.cpp b/gui/translationhandler.cpp
@@ -27,11 +27,11 @@ TranslationHandler::TranslationHandler(QObject *parent) :
         mTranslator(new QTranslator(this))
 {
     //Add our default languages
-    mNames  << QObject::tr("English")
-    << QObject::tr("Finnish")
-    << QObject::tr("Swedish")
-    << QObject::tr("German")
-    << QObject::tr("Russian");
+    mNames  << "English"
+    << "Finnish"
+    << "Swedish"
+    << "German"
+    << "Russian";
 
     mFiles  << "cppcheck_en"
     << "cppcheck_fi"
@@ -109,3 +109,30 @@ int TranslationHandler::GetCurrentLanguage() const
     return mCurrentLanguage;
 }
 
+int TranslationHandler::SuggestLanguage() const
+{
+    /*
+    Get language from system locale's name
+    QLocale::languageToString would return the languages full name and we
+    only want two-letter ISO 639 language code so we'll get it from
+    locale's name.
+    */
+    QString language = QLocale::system().name().left(2);
+    //qDebug()<<"Your language is"<<language;
+
+    //catenate that to the default language filename
+    QString file = QString("cppcheck_%1").arg(language);
+    //qDebug()<<"Language file could be"<<file;
+
+
+    //And see if we can find it from our list of language files
+    int index = mFiles.indexOf(file);
+
+    //If nothing found, return english
+    if (index < 0)
+    {
+        return 0;
+    }
+
+    return index;
+}
diff --git a/gui/translationhandler.h b/gui/translationhandler.h
@@ -33,6 +33,7 @@ class TranslationHandler : QObject
     const QStringList GetFiles();
     bool SetLanguage(const int index, QString &error);
     int GetCurrentLanguage() const;
+    int SuggestLanguage() const;
 protected:
     int mCurrentLanguage;
     QStringList mNames;

Original file line number	Diff line number	Diff line change
`@@ -167,11 +167,14 @@ void MainWindow::LoadSettings()`
`167`	`167`
`168`	`168`	`QString error = "";`
`169`	`169`
`170`		`- SetLanguage(mSettings->value(SETTINGS_LANGUAGE, 0).toInt());`
	`170`	`+ SetLanguage(mSettings->value(SETTINGS_LANGUAGE, mTranslation->SuggestLanguage()).toInt());`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`void MainWindow::SaveSettings()`
`174`	`174`	`{`
	`175`	`+ //Force toolbar checkbox value to be updated`
	`176`	`+ AboutToShowViewMenu();`
	`177`	`+`
`175`	`178`	`mSettings->setValue(SETTINGS_WINDOW_WIDTH, size().width());`
`176`	`179`	`mSettings->setValue(SETTINGS_WINDOW_HEIGHT, size().height());`
`177`	`180`	`mSettings->setValue(SETTINGS_WINDOW_MAXIMIZED, isMaximized());`