GUI: Implement stopping the compare.

kimmov · kimmov · commit 027c31f39c7e · 2009-06-02T02:01:53.000+03:00
Threads must be exited from check cleanly even though it takes small amount of time. Just terminating thread can have unpredictable side-effects (even weird crashes).
diff --git a/gui/checkthread.cpp b/gui/checkthread.cpp
@@ -40,22 +40,30 @@ void CheckThread::Check(Settings settings)
 
 void CheckThread::run()
 {
+    mState = Running;
     QString file;
     file = mResult.GetNextFile();
 
-    while (!file.isEmpty())
+    while (!file.isEmpty() && mState == Running)
     {
         qDebug() << "Checking file" << file;
         mCppcheck.addFile(file.toStdString());
         mCppcheck.check();
         mCppcheck.clearFiles();
         emit FileChecked(file);
 
-        file = mResult.GetNextFile();
+        if (mState == Running)
+            file = mResult.GetNextFile();
     }
+    if (mState == Running)
+        mState = Ready;
+	else
+        mState = Stopped;
 
     emit Done();
 }
 
-
-
+void CheckThread::stop()
+{
+    mState = Stopping;
+}
diff --git a/gui/checkthread.h b/gui/checkthread.h
@@ -49,6 +49,8 @@ class CheckThread : public QThread
     */
     void run();
 
+    void stop();
+
 
 signals:
 
@@ -60,6 +62,27 @@ class CheckThread : public QThread
 
     void FileChecked(const QString &file);
 protected:
+
+    /**
+    * @brief States for the check thread.
+    * Whole purpose of these states is to allow stopping of the checking. When
+    * stopping we say for the thread (Stopping) that "stop when current check
+    * has been completed. Thread must be stopped cleanly, just terminating thread
+    * likely causes unpredictable side-effedts.
+    */
+    enum State
+    {
+        Running, /**< The thread is checking. */
+        Stopping, /**< The thread will stop after current work. */
+        Stopped, /**< The thread has been stopped. */
+        Ready, /**< The thread is ready. */
+    };
+
+    /**
+    * @brief Thread's current execution state.
+    */
+    State mState;
+
     ThreadResult &mResult;
     /**
     * @brief Cppcheck itself
diff --git a/gui/mainwindow.cpp b/gui/mainwindow.cpp
@@ -105,8 +105,7 @@ MainWindow::MainWindow() :
 
     connect(&mActionReCheck, SIGNAL(triggered()), this, SLOT(ReCheck()));
 
-    //TODO: This crashed
-    //connect(&mActionStop, SIGNAL(triggered()), &mThread, SLOT(Stop()));
+    connect(&mActionStop, SIGNAL(triggered()), &mThread, SLOT(Stop()));
     connect(&mActionSave, SIGNAL(triggered()), this, SLOT(Save()));
 
     connect(&mActionAbout, SIGNAL(triggered()), this, SLOT(About()));
diff --git a/gui/threadhandler.cpp b/gui/threadhandler.cpp
@@ -124,7 +124,7 @@ void ThreadHandler::Stop()
 {
     for (int i = 0;i < mThreads.size();i++)
     {
-        mThreads[i]->terminate();
+        mThreads[i]->stop();
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ void ThreadHandler::Stop()`
`124`	`124`	`{`
`125`	`125`	`for (int i = 0;i < mThreads.size();i++)`
`126`	`126`	`{`
`127`		`- mThreads[i]->terminate();`
	`127`	`+ mThreads[i]->stop();`
`128`	`128`	`}`
`129`	`129`	`}`
`130`	`130`