Skip to content

Continue the work of Chrome 50 upgrade#5461

Merged
zcbenz merged 43 commits intomasterfrom
chrome50
May 13, 2016
Merged

Continue the work of Chrome 50 upgrade#5461
zcbenz merged 43 commits intomasterfrom
chrome50

Conversation

@zcbenz
Copy link
Copy Markdown
Contributor

@zcbenz zcbenz commented May 10, 2016 •
edited
Loading

  • Mac App Store build not building
  • ia32 target of Linux not building
  • Switch to Visual Studio 2015 for building
  • Upgrade to Node v6.1.0
  • Crash in renderer process: node::Buffer::CallbackInfo::CallbackInfo
  • Crash in renderer process: v8::internal::Isolate::FireBeforeCallEnteredCallback
  • Crash in renderer process: v8::internal::GlobalHandles::Node::Release()
  • Crash in renderer process: content::BlinkPlatformImpl::SetCompositorThread
  • crashReporter not working on x64 Windows
  • Linking error when building Release version on Windows

@zcbenz zcbenz force-pushed the chrome50 branch 2 times, most recently from 6139862 to 99ef57e Compare May 11, 2016 13:16
bbondy and others added 28 commits May 13, 2016 11:07
@bbondy @zcbenz
Add referrer_schems to AddAdditionalSchemes
8d4ed03
@bbondy @zcbenz
Remove Vorbis from CDM support
b78fe04 
See https://codereview.chromium.org/1690353002
@bbondy @zcbenz
Widevine AAC CDM no longer avail
dc79280 
See chromium ./third_party /widevine/cdm/widevine_cdm_common.h
@bbondy @zcbenz
No more GetCookieMonster
93e9cf4
@bbondy @zcbenz
LoadAccessTokensCallbackType -> LoadAccessTokensCallback
5fda9bc
@bbondy @zcbenz
Update to new pref service location in components
2da39d3
@bbondy @zcbenz
AccessTokenSet -> AccessTokenMap
82f3bb2
@bbondy @zcbenz
PermissionStatus constant update
8a2aebd
@bbondy @zcbenz
Iterator to use size_t
ff91aeb
@bbondy @zcbenz
WebFindOptions in its own header
c04353a
@bbondy @zcbenz
Remove user_gesture parameter from PermissionManager::RequestPermission
d889bde
@bbondy @zcbenz
Update to brave crashpad dep (Electron maintainer rebase this to use
f418ac5 
your ref)
@bbondy @zcbenz
GetNativeScreen -> GetScreen
7329367
@bbondy @zcbenz
Remove wwebaudio from web_preferences
48e62ac 
Becauseit doesn't exist there anymore
@bbondy @zcbenz
Fix GURL coonstructor from webkit string error
22863b9
@bbondy @zcbenz
Fix linking problem with IPC::MessageT
02d72c8 
IPC::MessageT<ChromeUtilityHostMsg_ProcessStarted_Meta, std::__1::tuple<>, void>::MessageT(IPC::Routing)
@bbondy @zcbenz
Minimum fixes needed for chromium_src
ce7c102
@bbondy @zcbenz
Add SkUserConfig.h with blank SkDebugf macro
0253aec 
This file was copied from:
./third_party/skia/include/config/SkUserConfig.h

But because of this linking error we needed to
define a macro for SkDebugf.

```
"SkDebugf(char const*, ...)", referenced from:
      SkBitmap::allocPixels(SkImageInfo const&, unsigned long) in
      libbrave_lib.a(brave_lib.native_desktop_media_list.o)
      ld: symbol(s) not found for architecture x86_64
```

There used to be a hack to copy this file here which was removed:
brave/libchromiumcontent@8de9d9e
@bbondy @zcbenz
Update linux menu overrides
f93fa53
@bbondy @zcbenz
Update x11 global shortcut listeners
37ccd34
@bbondy @zcbenz
Update PlatformCanvas to SKCanvas
900001e
@bbondy @zcbenz
Update SharedMemory buf constructor
a52dbf0
@bbondy @zcbenz
Update Brightray and libchromiumcontent v50 ref (Electron maintainer use
a965205 
your refs)
@bbondy @zcbenz
setBaseBackgroundColor moved to WebFrameWidget
e8c4fb6
@zcbenz
Simplify the check for web_frame_widget
35d9e37
@zcbenz
Do not remove the patch for Command key
9ccb495
@zcbenz
Update crashpad with AppKit patch
525e3ee
@zcbenz
Update libchromiumcontent to fix renderer process crash
9c0f298
@zcbenz zcbenz merged commit faf896d into master May 13, 2016
@zcbenz zcbenz deleted the chrome50 branch May 13, 2016 05:52
@bbondy
Copy link
Copy Markdown
Contributor

bbondy commented May 13, 2016

Nice to see 6.1 and VS2015 👍
Could you also merge in brightray's branch? Thanks!

@zcbenz
Copy link
Copy Markdown
Contributor Author

zcbenz commented May 13, 2016

Sure thing.

@anaisbetts
Copy link
Copy Markdown
Contributor

anaisbetts commented May 13, 2016 •
edited
Loading

We should make sure to call out the node 6.x breaking change of path.join(undefined, "foo") throwing now, I suspect it will break people /cc nodejs/node#5348

@rgbkrk
Copy link
Copy Markdown

rgbkrk commented May 13, 2016

That throws in v5.10.1 as well:

$ node
> process.version
'v5.10.1'
> path.join(undefined,'sdaf')
TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.join (path.js:1213:7)
    at repl:1:6
    at REPLServer.defaultEval (repl.js:269:27)
    at bound (domain.js:287:14)
    at REPLServer.runBound [as eval] (domain.js:300:12)
    at REPLServer.<anonymous> (repl.js:439:12)
    at emitOne (events.js:95:20)
    at REPLServer.emit (events.js:182:7)
    at REPLServer.Interface._onLine (readline.js:211:10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zcbenz @bbondy @anaisbetts @rgbkrk