Conversation
electron-roller
Bot
added
no-backport
semver/patch
3 tasks
codebytere
force-pushed
the
roller/node/main
branch
from
1b6a67f to
9b0c15c
Compare
nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up
This has diverged as a result of our revert of src,lb: reducing C++ calls of esm legacy main resolve
codebytere
force-pushed
the
roller/node/main
branch
from
9b0c15c to
5e450ba
Compare
codebytere
force-pushed
the
roller/node/main
branch
from
5e7696f to
e9cfecf
Compare
samuelmaddock
approved these changes
Jan 29, 2025
| if (context.withFileTypes) { | ||
| readdirResult = [ | ||
| [...readdirResult], readdirResult.map((p: string) => { | ||
| return internalBinding('fs').internalModuleStat(binding, path.join(pathArg, p)); |
Member
There was a problem hiding this comment.
Should we reference binding here and elsewhere instead?
Suggested change
| return internalBinding('fs').internalModuleStat(binding, path.join(pathArg, p)); | |
| return binding.internalModuleStat(binding, path.join(pathArg, p)); |
Member
There was a problem hiding this comment.
@samuelmaddock we monkey-patch internalModuleStat in this file so it needs to be this way unfortunately
jkleinsc
approved these changes
Jan 29, 2025
|
Release Notes Persisted
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Node.js to v22.13.1.
See all changes in v22.11.0..v22.13.1
Notes: Updated Node.js to v22.13.1.