chore: bump node to v20.11.0 (main) by electron-roller[bot] · Pull Request #40941 · electron/electron

electron-roller · 2024-01-10T13:00:32Z

Updating Node.js to v20.11.0.

Notes: Updated Node.js to v20.11.0.

codebytere · 2024-01-17T17:05:16Z

Seeing this test fail multiple times:

not ok 736 spellchecker without sandbox "after each" hook for "should detect correctly spelled words as correct"
  expected [ BrowserWindow{ id: 235, setBounds: [Function], _events: { blur: [Function], focus: [Function], show: [Function visibilityChanged], hide: [Function visibilityChanged], minimize: [Function visibilityChanged], maximize: [Function visibilityChanged], restore: [Function visibilityChanged], close: [Function] }, _eventsCount: 8, _browserViews: [], devToolsWebContents: null } ] to have a length of +0 but got 1
  AssertionError: expected [ BrowserWindow{ id: 235, setBounds: [Function], _events: { blur: [Function], focus: [Function], show: [Function visibilityChanged], hide: [Function visibilityChanged], minimize: [Function visibilityChanged], maximize: [Function visibilityChanged], restore: [Function visibilityChanged], close: [Function] }, _eventsCount: 8, _browserViews: [], devToolsWebContents: null } ] to have a length of +0 but got 1
      at closeWindow (electron/spec/lib/window-helpers.ts:34:31)
      at Context.<anonymous> (electron/spec/spellchecker-spec.ts:86:9)

on linux x64 - I can't reproduce it in my x64 codespace but it's failed too many times to be a flake i think. I'll investigate more and see what I can find.

jkleinsc · 2024-01-18T19:36:58Z

Seeing this test fail multiple times:

not ok 736 spellchecker without sandbox "after each" hook for "should detect correctly spelled words as correct"
  expected [ BrowserWindow{ id: 235, setBounds: [Function], _events: { blur: [Function], focus: [Function], show: [Function visibilityChanged], hide: [Function visibilityChanged], minimize: [Function visibilityChanged], maximize: [Function visibilityChanged], restore: [Function visibilityChanged], close: [Function] }, _eventsCount: 8, _browserViews: [], devToolsWebContents: null } ] to have a length of +0 but got 1
  AssertionError: expected [ BrowserWindow{ id: 235, setBounds: [Function], _events: { blur: [Function], focus: [Function], show: [Function visibilityChanged], hide: [Function visibilityChanged], minimize: [Function visibilityChanged], maximize: [Function visibilityChanged], restore: [Function visibilityChanged], close: [Function] }, _eventsCount: 8, _browserViews: [], devToolsWebContents: null } ] to have a length of +0 but got 1
      at closeWindow (electron/spec/lib/window-helpers.ts:34:31)
      at Context.<anonymous> (electron/spec/spellchecker-spec.ts:86:9)

on linux x64 - I can't reproduce it in my x64 codespace but it's failed too many times to be a flake i think. I'll investigate more and see what I can find.

test: fixup assertNotWindows #41045 fixed this issue, so I rebased this branch to pull in that fix.

This can't be enabled owing to BoringSSL incompatibilities. nodejs/node#50186

nodejs/node#51239

Incompatible with our asar logic, resulting in the following failure: > Failed to CompileAndCall electron script: electron/js2c/asar_bundle

nodejs/node#50421

…to upstream

release-clerk · 2024-01-18T21:16:48Z

Release Notes Persisted

Updated Node.js to v20.11.0.

electron-roller Bot requested a review from a team as a code owner January 10, 2024 13:00

electron-roller Bot added no-backport semver/patch backwards-compatible bug fixes labels Jan 10, 2024

electron-cation Bot added the new-pr 🌱 PR opened recently label Jan 10, 2024

codebytere self-assigned this Jan 10, 2024

electron-roller Bot requested a review from a team as a code owner January 10, 2024 21:10

electron-cation Bot removed the new-pr 🌱 PR opened recently label Jan 11, 2024

zcbenz force-pushed the roller/node/main branch 3 times, most recently from 391bb16 to 9cb100e Compare January 12, 2024 03:54

codebytere force-pushed the roller/node/main branch 3 times, most recently from 5c05061 to 9e1d9e1 Compare January 16, 2024 18:41

deepak1556 reviewed Jan 17, 2024

View reviewed changes

Comment thread script/generate-config-gypi.py Outdated

deepak1556 approved these changes Jan 17, 2024

View reviewed changes

ckerr approved these changes Jan 17, 2024

View reviewed changes

codebytere force-pushed the roller/node/main branch from 8b41069 to a0463ba Compare January 18, 2024 12:18

jkleinsc force-pushed the roller/node/main branch from a0463ba to c3f1027 Compare January 18, 2024 19:28

electron-roller Bot and others added 10 commits January 18, 2024 20:43

chore: bump node in DEPS to v20.11.0

4d1417b

module: bootstrap module loaders in shadow realm

b0c244a

nodejs/node#48655

src: add commit hash shorthand in zlib version

21d8f82

nodejs/node#50158

v8,tools: expose necessary V8 defines

dc666c8

nodejs/node#50820

esm: do not call getSource when format is commonjs

6752888

nodejs/node#50465

esm: fallback to readFileSync when source is nullish

e604a2d

nodejs/node#50825

vm: allow dynamic import with a referrer realm

cc66ea6

nodejs/node#50360

test: skip test-diagnostics-channel-memory-leak.js

cd3682d

nodejs/node#50327

esm: do not call getSource when format is commonjs

cda0cb4

nodejs/node#50465

lib: fix assert throwing different error messages in ESM and CJS

e87b61b

nodejs/node#50634

codebytere and others added 15 commits January 18, 2024 20:43

src: fix compatility with upcoming V8 12.1 APIs

ccb0131

nodejs/node#50709

deps: update base64 to 0.5.1

bfa6285

nodejs/node#50629

src: avoid silent coercion to signed/unsigned int

229fe18

nodejs/node#50663

src: fix compatility with upcoming V8 12.1 APIs

dc8f710

nodejs/node#50709

chore: fix patch indices

c6f6df2

chore: update patches

aa99108

test: disable TLS cipher test

4e25d43

This can't be enabled owing to BoringSSL incompatibilities. nodejs/node#50186

fix: check for Buffer and global definition in shadow realm

6e6000c

nodejs/node#51239

test: disable parallel/test-shadow-realm-custom-loader

29ed3ad

Incompatible with our asar logic, resulting in the following failure: > Failed to CompileAndCall electron script: electron/js2c/asar_bundle

chore: remove deleted parallel/test-crypto-modp1-error test

226fa46

test: make test-node-output-v8-warning generic

0bdb37e

nodejs/node#50421

chore: fixup ModuleWrap patch

efd4cec

test: match wpt/streams/transferable/transform-stream-members.any.js …

8033f6e

…to upstream

fix: sandbox is not enabled on arm

a573530

chore: disable v8 sandbox on ia32/arm

6d15f6e

codebytere force-pushed the roller/node/main branch from c3f1027 to 6d15f6e Compare January 18, 2024 19:43

jkleinsc approved these changes Jan 18, 2024

View reviewed changes

jkleinsc merged commit f4ee3c1 into main Jan 18, 2024

jkleinsc deleted the roller/node/main branch January 18, 2024 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump node to v20.11.0 (main)#40941

chore: bump node to v20.11.0 (main)#40941
jkleinsc merged 25 commits intomainfrom
roller/node/main

electron-roller Bot commented Jan 10, 2024

Uh oh!

Uh oh!

codebytere commented Jan 17, 2024

Uh oh!

jkleinsc commented Jan 18, 2024

Uh oh!

release-clerk Bot commented Jan 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

electron-roller Bot commented Jan 10, 2024

Uh oh!

Uh oh!

codebytere commented Jan 17, 2024

Uh oh!

jkleinsc commented Jan 18, 2024

Uh oh!

release-clerk Bot commented Jan 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants