fix: console windows from ELECTRON_RUN_AS_NODE instances#31963
Merged
deepak1556 merged 1 commit intomainfrom Nov 23, 2021
Merged
fix: console windows from ELECTRON_RUN_AS_NODE instances#31963deepak1556 merged 1 commit intomainfrom
deepak1556 merged 1 commit intomainfrom
Conversation
codebytere
approved these changes
Nov 23, 2021
|
Release Notes Persisted
|
This was referenced Nov 23, 2021
Contributor
|
I have automatically backported this PR to "17-x-y", please check out #31972 |
Contributor
|
I have automatically backported this PR to "16-x-y", please check out #31973 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
When adopting 16.8.0 our global console window patch was replaced to adopt nodejs/node#39712 but it was not adopted for
ELECTRON_RUN_AS_NODEinstances leading to the creation of console windows when spawning console applications from a forked process.Refs microsoft/vscode#137481
Gist example: https://gist.github.com/deepak1556/eefed2d47fada30c15ab9077d1532d0b
Checklist
npm testpassesRelease Notes
Notes: fix console windows from ELECTRON_RUN_AS_NODE instances