Support multiget actions during split #141560
Conversation
Tim-Brooks
added
>non-issue
:Distributed/CRUD
|
Pinging @elastic/es-distributed (Team:Distributed) |
bcully
left a comment
bcully
left a comment
There was a problem hiding this comment.
Looks good - had a couple of questions, nothing major. Will there be a corresponding end-to-end test for this?
| refresh = in.readBoolean(); | ||
| realtime = in.readBoolean(); | ||
| forceSyntheticSource = in.readBoolean(); | ||
| splitShardCountSummary = new SplitShardCountSummary(in); |
There was a problem hiding this comment.
doesn't this need a transport version guard?
| private final ProjectMetadata projectMetadata; | ||
| private final BiConsumer<MultiGetShardRequest, ActionListener<MultiGetShardResponse>> executeRequest; | ||
|
|
||
| private MultiGetShardSplitHelper() { |
There was a problem hiding this comment.
does this do anything? I thought the existence of the constructor with args meant there already was no default no arg constructor?
| * Helper class for coordinating multi-get shard requests during index resharding/splitting. | ||
| * Similar to ReplicationSplitHelper, this handles the logic for detecting stale requests | ||
| * and splitting them across multiple shards when the coordinator's view is one split behind. | ||
| * | ||
| * This class provides both utility methods for splitting/combining requests and coordination | ||
| * logic for executing split requests. |
There was a problem hiding this comment.
Would it be worth trying to share logic between this and ReplicationSplitHelper? I suppose it means introducing some potentially annoying abstractions, but they do look pretty similar and I wonder whether it would help with maintenance. Potentially a followup?
3 participants
This commit ensures that multiget is properly delegated to new target
shards in the middle of a split.