I think these changes should work without creating a buffer for each send operation, although c++14 is required here:

diff --git a/http_examples.cpp b/http_examples.cpp
index 3e16a9c..39ad46c 100644
--- a/http_examples.cpp
+++ b/http_examples.cpp
@@ -173,16 +173,17 @@ int main() {
         // Trick to define a recursive function within this scope (for example purposes)
         class FileServer {
         public:
-          static void read_and_send(const shared_ptr<HttpServer::Response> &response, const shared_ptr<ifstream> &ifs) {
+          static void read_and_send(const shared_ptr<HttpServer::Response> &response,
+                                    const shared_ptr<ifstream> &ifs,
+                                    vector<char> &&buffer) {
             // Read and send 128 KB at a time
-            static vector<char> buffer(131072); // Safe when server is running on one thread
             streamsize read_length;
             if((read_length = ifs->read(&buffer[0], static_cast<streamsize>(buffer.size())).gcount()) > 0) {
               response->write(&buffer[0], read_length);
               if(read_length == static_cast<streamsize>(buffer.size())) {
-                response->send([response, ifs](const SimpleWeb::error_code &ec) {
+                response->send([ response, ifs, buffer = move(buffer) ](const SimpleWeb::error_code &ec) mutable {
                   if(!ec)
-                    read_and_send(response, ifs);
+                    read_and_send(response, ifs, move(buffer));
                   else
                     cerr << "Connection interrupted" << endl;
                 });
@@ -190,7 +191,7 @@ int main() {
             }
           }
         };
-        FileServer::read_and_send(response, ifs);
+        FileServer::read_and_send(response, ifs, vector<char>(131072));
       }
       else
         throw invalid_argument("could not read file");

thread safe example for Fileserver #215

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions