Skip to content

Feature summary#51

Merged
ukumark merged 12 commits intodevfrom
feature-summary
Feb 5, 2020
Merged

Feature summary#51
ukumark merged 12 commits intodevfrom
feature-summary

Conversation

@huyvoo
Copy link
Copy Markdown
Contributor

@huyvoo huyvoo commented Jan 24, 2020

Did not mean to delete this branch.

@DynataRidley
Copy link
Copy Markdown
Contributor

Can you add a usage example in the readme file?

@DynataRidley
Copy link
Copy Markdown
Contributor

Specifically under the "Supported API Functions" header like the other endpoints. I think it's OK that it doesn't have a link yet but it would be good to add the function there anyway.

Copy link
Copy Markdown
Contributor

@dynata-bradley dynata-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this PR is fine, but having not seen the documentation on the endpoint I have no way of knowing.

[Get Project Detailed Report](https://developers.dynata.com/demand-api-reference/core-resources/projects/get-project-detailed-report): get_project_detailed_report(project_id)
[Get Pricing & Feasibility](https://developers.dynata.com/demand-api-reference/core-resources/pricing-feasibility/get-pricing-feasibility): get_feasibility(project_id)
[Get Invoice PDF](https://developers.dynata.com/demand-api-reference/billing_invoicing/invoicing/get-invoices): get_invoice(project_id)
[Get Invoices Summary PDF](https://developers.dynata.com): get_invoices_summary(\*\*kwargs)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see documentation for this endpoint at that link?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rohan will take care of adding documentation once it is pushed out into production.

@huyvoo huyvoo requested a review from ukumark February 5, 2020 19:44
@ukumark ukumark merged commit 744e6d9 into dev Feb 5, 2020
@dynata-bradley dynata-bradley deleted the feature-summary branch February 6, 2020 10:02
@dynata-bradley
Copy link
Copy Markdown
Contributor

Since this was merged to dev I've opened issue #56 for the associated remaining technical debt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants