Skip to content

Conversation

@KevinStrong
Copy link
Contributor

@KevinStrong KevinStrong commented Jan 23, 2023

Upgrade the 3rd party libraries scribejava and flickr4java.

They have to be upgraded simultaneously because the flick4java interface exports scribejava.

The DTP interface, specifically with regard to declared exceptions, is kept that same despite changes to how flickr4java declares thrown exceptions.

@KevinStrong KevinStrong force-pushed the upgrade-scribe-and-flickr4java branch 4 times, most recently from a8eaff3 to 35af9ad Compare January 23, 2023 17:17
headersMap.put("X-Smug-AlbumUri", albumUri);
headersMap.put("X-Smug-ResponseType", "JSON");
headersMap.put("X-Smug-Version", "v2");
headersMap.put("X-Smug-AlbumOverflow", "1");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do this, where is it coming from? @seehamrun

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove this

@KevinStrong KevinStrong force-pushed the upgrade-scribe-and-flickr4java branch 3 times, most recently from 6b00059 to 0785ed4 Compare January 23, 2023 17:29
@KevinStrong KevinStrong marked this pull request as ready for review January 23, 2023 17:30
seehamrun
seehamrun previously approved these changes Jan 24, 2023
@KevinStrong KevinStrong force-pushed the upgrade-scribe-and-flickr4java branch 2 times, most recently from 67e3f98 to d3b362a Compare January 24, 2023 19:01
seehamrun
seehamrun previously approved these changes Jan 24, 2023
@KevinStrong KevinStrong force-pushed the upgrade-scribe-and-flickr4java branch 2 times, most recently from 2816fd0 to aeefbf6 Compare January 24, 2023 20:34
@KevinStrong KevinStrong force-pushed the upgrade-scribe-and-flickr4java branch from aeefbf6 to ffeff5a Compare January 24, 2023 21:19
@seehamrun seehamrun merged commit 66e5e29 into dtinit:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants