Make HNS check and client instantiation more reliable #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #478 +/- ##
======================================
Coverage 94.2% 94.2%
======================================
Files 23 23
Lines 1745 1753 +8
======================================
+ Hits 1645 1653 +8
Misses 100 100
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #470 and #476 report problems with credentials being used that cannot determine if HNS is enabled on the storage account.
This fix does two things:
_sharedthat is implemented in both libraries (SharedKeyCredentialPolicy). Other kinds of credentials are properly isolated to a shared underlying library in the Azure SDK codebase.get_account_informationresults inResourceNotFound, which indicates the credential does not have permission to get this metadata, we fall back to trying to see if the root dir in the container exists and hashdi_folder=Truewhich should only be the case when HNS is enabled.Closes #470