Skip to content

fix(formula): fix cell custom properties would trigger formula calculation #6408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wpxp123456 wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix(formula): fix cell custom properties would trigger formula calculation #6408

wpxp123456 wants to merge 3 commits into from
+8 −1

Conversation

@wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Dec 30, 2025

close #6407

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 requested a review from Dushusir as a code owner December 30, 2025 12:27
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025 •
edited
Loading

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

@wpxp123456 wpxp123456 closed this Dec 30, 2025
@wpxp123456 wpxp123456 reopened this Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025 •
edited
Loading

Playwright test results

passed  27 passed

Details

stats  27 tests across 12 suites
duration  6 minutes, 33 seconds
commit  1ce4256
info  For more information, see full report

@wpxp123456 wpxp123456 removed the qa:untested This PR is ready to be tested label Dec 30, 2025
jikkai
jikkai requested changes Dec 30, 2025
View reviewed changes
Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jikkai jikkai jikkai requested changes

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] setCustomMetaData will cause the formula to be lost

3 participants

@wpxp123456 @jikkai