UPD: better thread-safe TFileSource reference counting#2255
Open
xBZZZZ wants to merge 1 commit intodoublecmd:masterfrom
Open
UPD: better thread-safe TFileSource reference counting#2255xBZZZZ wants to merge 1 commit intodoublecmd:masterfrom
xBZZZZ wants to merge 1 commit intodoublecmd:masterfrom
Conversation
1. works with latest freepascal ( https://gitlab.com/freepascal.org/fpc/source/-/commit/c3f80014b41db2cb4a6fa50a50c2548a03000124#note_2431141761 ) 2. impossible to find IFileSource during constructing or destructing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: there is code like: find {subclass of
IFileSource} or create it if not founddoublecmd/src/filesources/uarchivefilesourceutil.pas
Lines 52 to 61 in b7b47b2
that is not thread safe, multiple of {subclass of
IFileSource} can be created if code like that runs on multiple threadstodo: test plugins (only tested
zip.wcx(seems like works))