Skip to content

Check 'ObjCCategoryDecl->getTypeParamList()' for null before trying to use the result.#655

Merged
tannergooding merged 5 commits into
dotnet:mainfrom
rolfbjarne:objccategorydecl-gettypeparamlist
Dec 22, 2025
Merged

Check 'ObjCCategoryDecl->getTypeParamList()' for null before trying to use the result.#655
tannergooding merged 5 commits into
dotnet:mainfrom
rolfbjarne:objccategorydecl-gettypeparamlist

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Dec 20, 2025

Copy link
Copy Markdown
Member

Also add a new test.

@rolfbjarne

Copy link
Copy Markdown
Member Author

Looks like the macOS job failed because the tests crashed?

The active test run was aborted. Reason: Test host process crashed

Could it be that the tests don't use libClangSharp.dylib from the repository, but the published one instead?

@tannergooding

Copy link
Copy Markdown
Member

Could it be that the tests don't use libClangSharp.dylib from the repository, but the published one instead?

Due to the requirements/expense to build libClangSharp, it isn't built as part of CI. It is rather only built on demand and so the test here likely needs to be disabled until after the change goes in and a new set of binaries can be published.

Comment thread sources/libClangSharp/ClangSharp.cpp Outdated
@rolfbjarne

Copy link
Copy Markdown
Member Author

test here likely needs to be disabled until after the change goes in and a new set of binaries can be published.

Ok, I've disabled the test.

@tannergooding tannergooding merged commit fa748a3 into dotnet:main Dec 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants