add support for some missing API entries#960
Closed
troubadout wants to merge 2 commits intodocker-java:3.0.xfrom
Closed
add support for some missing API entries#960troubadout wants to merge 2 commits intodocker-java:3.0.xfrom
troubadout wants to merge 2 commits intodocker-java:3.0.xfrom
Conversation
troubadout
force-pushed
the
3.0.x
branch
2 times, most recently
from
3a378cd to
300e4b1
Compare
Codecov Report
@@ Coverage Diff @@
## 3.0.x #960 +/- ##
=========================================
+ Coverage 71.7% 71.71% +0.01%
=========================================
Files 306 306
Lines 6882 6888 +6
Branches 516 516
=========================================
+ Hits 4935 4940 +5
- Misses 1648 1651 +3
+ Partials 299 297 -2
Continue to review full report at Codecov.
|
KostyaSha
reviewed
Dec 5, 2017
| @Override | ||
| @JsonIgnore | ||
| public String getIpcMode() { | ||
| return hostConfig.getIpcMode(); |
Member
There was a problem hiding this comment.
Don't proxy hostconfig settings, hostconfig should be configured separately
KostyaSha
requested changes
Feb 20, 2018
Member
KostyaSha
left a comment
KostyaSha
left a comment
There was a problem hiding this comment.
Use some collection instead array
Member
|
please switch to 3.1 releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is