docker-java · KostyaSha · Sep 29, 2017 · Sep 6, 2017 · Sep 6, 2017 · Sep 7, 2017
diff --git a/.travis.yml b/.travis.yml
@@ -22,6 +22,9 @@ env:
     - COVERITY_SCAN_NOTIFICATION_EMAIL="[email protected]"
 
   matrix:
+#    - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="17.09.0~ce-0~ubuntu-trusty"
+#    - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="17.09.0~ce-0~ubuntu-trusty"
+#    - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="17.06.2~ce-0~ubuntu-trusty" DEPLOY=true COVERITY=true
     - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" DEPLOY=true COVERITY=true
     - repo="main" DOCKER_HOST="tcp://127.0.0.1:2377" DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty" SWARM_VERSION="1.2.6"
     - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="17.05.0~ce-0~ubuntu-trusty"
@@ -30,10 +33,10 @@ env:
     - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="1.13.1-0~ubuntu-trusty"
     - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.12.6-0~ubuntu-trusty"
     - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="1.12.6-0~ubuntu-trusty"
-    - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.11.2-0~trusty"
-    - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="1.11.2-0~trusty"
-    - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.10.3-0~trusty"
-    - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="1.10.3-0~trusty"
+#    - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.11.2-0~trusty"
+#    - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="1.11.2-0~trusty"
+#    - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.10.3-0~trusty"
+#    - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="1.10.3-0~trusty"
 #    - repo="testing" DOCKER_HOST="tcp://127.0.0.1:2375"
 #    - repo="testing" DOCKER_HOST="unix:///var/run/docker.sock"
 #    - repo="experimental" DOCKER_HOST="tcp://127.0.0.1:2375"

diff --git a/.travis/travis-before-install.sh b/.travis/travis-before-install.sh
@@ -45,8 +45,9 @@ sudo -E stop docker
 # sudo apt-get -f install
 # sudo dpkg -i "$(ls *${DOCKER_VERSION}*)"
 #popd
-#rm -f "src/test/resources/logback.xml"
-mv "src/test/resources/travis-logback.xml" "src/test/resources/logback.xml"
+rm -f "src/test/resources/logback.xml"
+#rm -f "src/test/resources/travis-logback.xml"
+mv "src/test/resources/travis-logback.xml" "src/test/resources/logback-test.xml"
 
 # https://github.com/docker/docker/issues/18113
 sudo rm /var/lib/docker/network/files/local-kv.db

diff --git a/pom.xml b/pom.xml
@@ -57,7 +57,7 @@
 		<jdk.source>1.7</jdk.source>
 		<jdk.target>1.7</jdk.target>
 
-		<jersey.version>2.23.1</jersey.version>
+		<jersey.version>2.26</jersey.version>
 		<jackson-jaxrs.version>2.6.4</jackson-jaxrs.version>
 		<httpclient.version>4.5</httpclient.version><!-- 4.5.1-4.5.2 broken -->
 		<commons-compress.version>1.12</commons-compress.version>
@@ -71,8 +71,7 @@
 		<guava.version>19.0</guava.version>
 
 		<!-- test dependencies -->
-		<logback.version>1.1.7</logback.version>
-		<testng.version>6.9.10</testng.version>
+		<logback.version>1.2.3</logback.version>
 		<netty.version>4.1.14.Final</netty.version>
 		<hamcrest.library.version>1.3</hamcrest.library.version>
 		<hamcrest.jpa-matchers>1.8</hamcrest.jpa-matchers>
@@ -83,8 +82,8 @@
 		<maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>
 		<maven-compiler-plugin.version>3.5.1</maven-compiler-plugin.version>
 		<maven-release-plugin.version>2.5.3</maven-release-plugin.version>
-		<maven-surefire-plugin.version>2.19.1</maven-surefire-plugin.version>
-		<maven-failsafe-plugin.version>2.19.1</maven-failsafe-plugin.version>
+		<maven-surefire-plugin.version>2.20</maven-surefire-plugin.version>
+		<maven-failsafe-plugin.version>2.20</maven-failsafe-plugin.version>
 		<maven-antrun-plugin.version>1.8</maven-antrun-plugin.version>
 		<maven-bundlor-plugin.version>1.1.2.RELEASE</maven-bundlor-plugin.version>
 		<maven-build-helper-plugin.version>3.0.0</maven-build-helper-plugin.version>
@@ -122,6 +121,11 @@
 			<artifactId>jersey-client</artifactId>
 			<version>${jersey.version}</version>
 		</dependency>
+		<dependency>
+			<groupId>org.glassfish.jersey.inject</groupId>
+			<artifactId>jersey-hk2</artifactId>
+			<version>${jersey.version}</version>
+		</dependency>
 		<dependency>
 			<groupId>com.kohlschutter.junixsocket</groupId>
 			<artifactId>junixsocket-common</artifactId>
@@ -189,13 +193,6 @@
 			<scope>test</scope>
 		</dependency>
 
-		<dependency>
-			<groupId>org.testng</groupId>
-			<artifactId>testng</artifactId>
-			<version>${testng.version}</version>
-			<scope>test</scope>
-		</dependency>
-
 		<dependency>
 			<groupId>org.hamcrest</groupId>
 			<artifactId>hamcrest-library</artifactId>
@@ -430,7 +427,7 @@
 				<version>${maven-surefire-plugin.version}</version>
 				<configuration>
 					<rerunFailingTestsCount>3</rerunFailingTestsCount>
-					<excludedGroups>integration,integration-auth,swarm-integration</excludedGroups>
+					<excludedGroups>com.github.dockerjava.junit.category.Integration</excludedGroups>
 				</configuration>
 			</plugin>
 
@@ -444,19 +441,17 @@
 							<goal>integration-test</goal>
 							<goal>verify</goal>
 						</goals>
-						<configuration>
-							<rerunFailingTestsCount>3</rerunFailingTestsCount>
-							<useUnlimitedThreads>true</useUnlimitedThreads>
-							<perCoreThreadCount>true</perCoreThreadCount>
-							<threadCount>1</threadCount>
-							<groups>integration</groups>
-							<excludedGroups>integration-auth,swarm-integration</excludedGroups>
-							<includes>
-								<include>**/*Test.java</include>
-							</includes>
-						</configuration>
 					</execution>
 				</executions>
+				<configuration>
+					<rerunFailingTestsCount>3</rerunFailingTestsCount>
+					<!--<useUnlimitedThreads>true</useUnlimitedThreads>-->
+					<perCoreThreadCount>true</perCoreThreadCount>
+					<threadCount>1</threadCount>
+					<parallel>classes</parallel>
+					<groups>com.github.dockerjava.junit.category.Integration</groups>
+					<excludedGroups>com.github.dockerjava.junit.category.AuthIntegration,com.github.dockerjava.junit.category.SwarmModeIntegration</excludedGroups>
+				</configuration>
 			</plugin>
 			<plugin>
 				<groupId>org.apache.maven.plugins</groupId>

diff --git a/src/main/java/com/github/dockerjava/core/RemoteApiVersion.java b/src/main/java/com/github/dockerjava/core/RemoteApiVersion.java
@@ -77,6 +77,10 @@ public class RemoteApiVersion implements Serializable {
      */
     public static final RemoteApiVersion VERSION_1_25 = RemoteApiVersion.create(1, 25);
 
+    public static final RemoteApiVersion VERSION_1_26 = RemoteApiVersion.create(1, 26);
+    public static final RemoteApiVersion VERSION_1_27 = RemoteApiVersion.create(1, 27);
+    public static final RemoteApiVersion VERSION_1_29 = RemoteApiVersion.create(1, 29);
+
 
     /**
      * Unknown, docker doesn't reflect reality. I.e. we implemented method, but for javadoc it not clear when it was added.
@@ -88,6 +92,11 @@ public boolean isGreaterOrEqual(final RemoteApiVersion other) {
             return false;
         }
 
+        @Override
+        public boolean isGreater(RemoteApiVersion other) {
+            return false;
+        }
+
         @Override
         public String toString() {
             return MoreObjects.toStringHelper(this).addValue("UNKNOWN_VERSION").toString();
@@ -146,6 +155,11 @@ public boolean isGreaterOrEqual(final RemoteApiVersion other) {
         return false;
     }
 
+    public boolean isGreater(final RemoteApiVersion other) {
+        return major > other.major || (major == other.major && minor > other.minor);
+
+    }
+
     /**
      * @return String representation of version. i.e. "1.22"
      */
@@ -179,4 +193,5 @@ public String toString() {
     public String asWebPathPart() {
         return "v" + major + "." + minor;
     }
+
 }
diff --git a/src/main/java/com/github/dockerjava/core/command/AttachContainerCmdImpl.java b/src/main/java/com/github/dockerjava/core/command/AttachContainerCmdImpl.java
@@ -8,24 +8,10 @@
 import com.github.dockerjava.api.model.Frame;
 
 /**
- * Attach to container
- *
- * @param logs
- *            - true or false, includes logs. Defaults to false.
- *
- * @param followStream
- *            - true or false, return stream. Defaults to false.
- * @param stdout
- *            - true or false, includes stdout log. Defaults to false.
- * @param stderr
- *            - true or false, includes stderr log. Defaults to false.
- * @param stdin
- *            - null or {@link InputStream}, pass stream to stdin of the container.
- * @param timestamps
- *            - true or false, if true, print timestamps for every log line. Defaults to false.
+ * Attach to container.
  */
-public class AttachContainerCmdImpl extends AbstrAsyncDockerCmd<AttachContainerCmd, Frame> implements
-        AttachContainerCmd {
+public class AttachContainerCmdImpl extends AbstrAsyncDockerCmd<AttachContainerCmd, Frame>
+        implements AttachContainerCmd {
 
     private String containerId;
 

diff --git a/src/test/java/com/github/dockerjava/api/ModelsSerializableTest.java b/src/test/java/com/github/dockerjava/api/ModelsSerializableTest.java
@@ -7,9 +7,9 @@
 import com.github.dockerjava.api.model.ResponseItem;
 import com.google.common.reflect.ClassPath.ClassInfo;
 import org.apache.commons.lang.reflect.FieldUtils;
+import org.junit.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.testng.annotations.Test;
 
 import java.io.IOException;
 import java.io.Serializable;

diff --git a/src/test/java/com/github/dockerjava/api/command/InspectContainerResponseTest.java b/src/test/java/com/github/dockerjava/api/command/InspectContainerResponseTest.java
@@ -17,23 +17,22 @@
 
 import com.fasterxml.jackson.databind.JavaType;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import com.github.dockerjava.api.model.Event;
 import com.github.dockerjava.core.RemoteApiVersion;
-import static com.github.dockerjava.test.serdes.JSONSamples.testRoundTrip;
-import java.io.IOException;
+import org.junit.Test;
 
-import org.testng.annotations.Test;
+import java.io.IOException;
 
+import static com.github.dockerjava.test.serdes.JSONSamples.testRoundTrip;
 import static com.github.dockerjava.test.serdes.JSONTestHelper.testRoundTrip;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.containsString;
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.isEmptyString;
 import static org.hamcrest.Matchers.nullValue;
 import static org.hamcrest.core.IsNot.not;
-import static org.testng.Assert.assertEquals;
-import static org.testng.Assert.assertFalse;
-import static org.testng.Assert.assertTrue;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 /**
  * Tests for {@link InspectContainerResponse}.

diff --git a/src/test/java/com/github/dockerjava/api/command/InspectExecResponseTest.java b/src/test/java/com/github/dockerjava/api/command/InspectExecResponseTest.java
@@ -3,7 +3,7 @@
 import com.fasterxml.jackson.databind.JavaType;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.github.dockerjava.core.RemoteApiVersion;
-import org.testng.annotations.Test;
+import org.junit.Test;
 
 import static com.github.dockerjava.test.serdes.JSONSamples.testRoundTrip;
 import static org.hamcrest.MatcherAssert.assertThat;

diff --git a/src/test/java/com/github/dockerjava/api/command/InspectImageResponseTest.java b/src/test/java/com/github/dockerjava/api/command/InspectImageResponseTest.java
@@ -3,7 +3,7 @@
 import com.fasterxml.jackson.databind.JavaType;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.github.dockerjava.api.model.ContainerConfig;
-import org.testng.annotations.Test;
+import org.junit.Test;
 
 import java.io.IOException;
 import java.util.Collections;
@@ -191,7 +191,7 @@ public void serder1_22_inspect_doc() throws IOException {
     }
 
     @Test
-    private void testOverlayNetworkRootDir() throws IOException {
+    public void testOverlayNetworkRootDir() throws IOException {
         final ObjectMapper mapper = new ObjectMapper();
         final JavaType type = mapper.getTypeFactory().constructType(InspectImageResponse.class);
 

diff --git a/src/test/java/com/github/dockerjava/api/model/AccessModeTest.java b/src/test/java/com/github/dockerjava/api/model/AccessModeTest.java
@@ -1,12 +1,18 @@
 package com.github.dockerjava.api.model;
 
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
 import static com.github.dockerjava.api.model.AccessMode.rw;
-import static org.testng.Assert.assertEquals;
+import static org.junit.Assert.assertEquals;
 
-import org.testng.annotations.Test;
 
 public class AccessModeTest {
 
+    @Rule
+    public ExpectedException expectedEx = ExpectedException.none();
+
     @Test
     public void defaultAccessMode() {
         assertEquals(AccessMode.DEFAULT, rw);
@@ -22,8 +28,11 @@ public void fromString() {
         assertEquals(AccessMode.valueOf("rw"), rw);
     }
 
-    @Test(expectedExceptions = IllegalArgumentException.class, expectedExceptionsMessageRegExp = "No enum const.*")
+    @Test
     public void fromIllegalString() {
+        expectedEx.expect(IllegalArgumentException.class);
+        expectedEx.expectMessage("No enum const");
+
         AccessMode.valueOf("xx");
     }
 

diff --git a/src/test/java/com/github/dockerjava/api/model/AuthConfigTest.java b/src/test/java/com/github/dockerjava/api/model/AuthConfigTest.java
@@ -3,7 +3,7 @@
 import com.fasterxml.jackson.databind.JavaType;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.github.dockerjava.core.RemoteApiVersion;
-import org.testng.annotations.Test;
+import org.junit.Test;
 
 import java.io.IOException;
 
@@ -12,7 +12,7 @@
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.notNullValue;
-import static org.testng.Assert.assertEquals;
+import static org.junit.Assert.assertEquals;
 
 public class AuthConfigTest {
 

diff --git a/src/test/java/com/github/dockerjava/api/model/BindTest.java b/src/test/java/com/github/dockerjava/api/model/BindTest.java
@@ -1,15 +1,20 @@
 package com.github.dockerjava.api.model;
 
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
 import static com.github.dockerjava.api.model.AccessMode.ro;
 import static com.github.dockerjava.api.model.AccessMode.rw;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.nullValue;
 import static org.hamcrest.core.Is.is;
 
-import org.testng.annotations.Test;
-
 public class BindTest {
 
+    @Rule
+    public ExpectedException expectedEx = ExpectedException.none();
+
     @Test
     public void parseUsingDefaultAccessMode() {
         Bind bind = Bind.parse("/host:/container");
@@ -128,18 +133,27 @@ public void parseReadOnlySEL() {
         assertThat(bind.getPropagationMode(), is(PropagationMode.DEFAULT_MODE));
     }
 
-    @Test(expectedExceptions = IllegalArgumentException.class, expectedExceptionsMessageRegExp = "Error parsing Bind.*")
+    @Test
     public void parseInvalidAccessMode() {
+        expectedEx.expect(IllegalArgumentException.class);
+        expectedEx.expectMessage( "Error parsing Bind");
+
         Bind.parse("/host:/container:xx");
     }
 
-    @Test(expectedExceptions = IllegalArgumentException.class, expectedExceptionsMessageRegExp = "Error parsing Bind 'nonsense'")
+    @Test
     public void parseInvalidInput() {
+        expectedEx.expect(IllegalArgumentException.class);
+        expectedEx.expectMessage("Error parsing Bind 'nonsense'");
+
         Bind.parse("nonsense");
     }
 
-    @Test(expectedExceptions = IllegalArgumentException.class, expectedExceptionsMessageRegExp = "Error parsing Bind 'null'")
+    @Test
     public void parseNull() {
+        expectedEx.expect(IllegalArgumentException.class);
+        expectedEx.expectMessage("Error parsing Bind 'null'");
+
         Bind.parse(null);
     }