Inspect container command now shows sizes if requested#572
Merged
marcuslinke merged 3 commits intodocker-java:masterfrom May 12, 2016
AE9999:AddSizeRootFs
Merged
Inspect container command now shows sizes if requested#572marcuslinke merged 3 commits intodocker-java:masterfrom AE9999:AddSizeRootFs
marcuslinke merged 3 commits intodocker-java:masterfrom
AE9999:AddSizeRootFs
Conversation
Current coverage is 23.80%
@@ master #572 diff @@
==========================================
Files 296 296
Lines 6129 6134 +5
Methods 0 0
Messages 0 0
Branches 532 533 +1
==========================================
+ Hits 1459 1460 +1
- Misses 4585 4589 +4
Partials 85 85
|
Contributor
|
@AE9999 Thanks for adding this. Would it be possible for you to add a test case please? |
Author
|
Will do |
|
|
||
| InspectContainerCmd withSize(Boolean showSize); | ||
|
|
||
| boolean getSize(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I understand the docker command line interface, you can request the current size of an Image. I did not see this functionality in your API, but needed it for a project and have added it myself. Please feel free to copy it & thanks for your hard work :-)
Best wishes,
AE
This change is