Skip to content

Inspect container command now shows sizes if requested#572

Merged
marcuslinke merged 3 commits intodocker-java:masterfrom
AE9999:AddSizeRootFs
May 12, 2016
Merged

Inspect container command now shows sizes if requested#572
marcuslinke merged 3 commits intodocker-java:masterfrom
AE9999:AddSizeRootFs

Conversation

@AE9999
Copy link
Copy Markdown

@AE9999 AE9999 commented May 6, 2016

As I understand the docker command line interface, you can request the current size of an Image. I did not see this functionality in your API, but needed it for a project and have added it myself. Please feel free to copy it & thanks for your hard work :-)

Best wishes,

AE


This change is Reviewable

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 6, 2016

Current coverage is 23.80%

Merging #572 into master will decrease coverage by -<.01%

  1. File ...rResultCallback.java (not in diff) was modified. more
    • Misses +1
    • Partials 0
    • Hits 0
@@             master       #572   diff @@
==========================================
  Files           296        296          
  Lines          6129       6134     +5   
  Methods           0          0          
  Messages          0          0          
  Branches        532        533     +1   
==========================================
+ Hits           1459       1460     +1   
- Misses         4585       4589     +4   
  Partials         85         85          

Powered by Codecov. Last updated by 1ab6e63...61869c8

@marcuslinke
Copy link
Copy Markdown
Contributor

@AE9999 Thanks for adding this. Would it be possible for you to add a test case please?

@AE9999
Copy link
Copy Markdown
Author

AE9999 commented May 9, 2016

Will do

@marcuslinke marcuslinke merged commit 72b2e73 into docker-java:master May 12, 2016
@marcuslinke marcuslinke changed the title Docker inspect command now shows sizes if request. Inspect container command now shows sizes if requested May 12, 2016

InspectContainerCmd withSize(Boolean showSize);

boolean getSize();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be object?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed while merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants