Implement container rename api#504
Closed
lujian0571 wants to merge 4 commits intodocker-java:masterfrom
lujian0571:master
Closed
Implement container rename api#504lujian0571 wants to merge 4 commits intodocker-java:masterfrom lujian0571:master
lujian0571 wants to merge 4 commits intodocker-java:masterfrom
lujian0571:master
Conversation
| /** | ||
| * rename a container. | ||
| * | ||
| * Created by lujian on 16/3/16. |
Member
There was a problem hiding this comment.
use @author javadoc without the date
Current coverage is
|
| try { | ||
| dockerClient.restartContainerCmd("non-existing").exec(); | ||
| fail("expected NotFoundException"); | ||
| } catch (NotFoundException e) { |
Member
There was a problem hiding this comment.
Should have expected test annotation
Member
|
Please check when this method appeared and mark it in javadoc for cmds. |
| import javax.annotation.Nonnull; | ||
|
|
||
| /** | ||
| * rename a container. |
Member
There was a problem hiding this comment.
Please start with capital letter :)
Member
|
Thanks, i will handle this pr on weekend. |
Member
|
And it appeared in 1.17! |
Member
|
Thanks for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.docker.com/engine/reference/api/docker_remote_api_v1.17/#rename-a-container
This change is