Skip to content

Expose cgroup-parent to the client#495

Closed
mavant wants to merge 1 commit intodocker-java:masterfrom
mavant:feature/cgroup-parent
Closed

Expose cgroup-parent to the client#495
mavant wants to merge 1 commit intodocker-java:masterfrom
mavant:feature/cgroup-parent

Conversation

@mavant
Copy link
Copy Markdown
Contributor

@mavant mavant commented Mar 10, 2016

This change is Review on Reviewable

@codecov-io
Copy link
Copy Markdown

Current coverage is 21.60%

Merging #495 into master will decrease coverage by -0.01% as of 0a072e1

@@            master   #495   diff @@
=====================================
  Files          290    290       
  Stmts         5944   5948     +4
  Branches       527    527       
  Methods          0      0       
=====================================
  Hit           1285   1285       
  Partial         83     83       
- Missed        4576   4580     +4

Review entire Coverage Diff as of 0a072e1

Powered by Codecov. Updated on successful CI builds.

@mavant mavant force-pushed the feature/cgroup-parent branch from c4c04fb to 970fbb6 Compare March 10, 2016 05:44
@KostyaSha
Copy link
Copy Markdown
Member

Starting from what API version does it appeared?

@mavant
Copy link
Copy Markdown
Contributor Author

mavant commented Mar 10, 2016

1.20, say the docs: https://docs.docker.com/engine/reference/api/docker_remote_api_v1.20/

You already added this to the HostConfig object in commt 1d2659d87128547ac02cceec2990ead297526df9; this just exposes it on CreateContainerCmdImpl.

@KostyaSha
Copy link
Copy Markdown
Member

please check the master code and version, we hope release it soon...

@mavant
Copy link
Copy Markdown
Contributor Author

mavant commented Mar 10, 2016

I'm not sure I understand, can you rephrase?

@KostyaSha
Copy link
Copy Markdown
Member

Sorry, i thought it targeted to 2.x branch.

@mavant
Copy link
Copy Markdown
Contributor Author

mavant commented Mar 10, 2016

Ah, I see. Nope, newer is better I always say :)

@KostyaSha KostyaSha self-assigned this Mar 20, 2016
@KostyaSha
Copy link
Copy Markdown
Member

Seems hostconfig is also missing properties :(

@KostyaSha
Copy link
Copy Markdown
Member

Ah, no, no way to serder CMDs :(

@KostyaSha
Copy link
Copy Markdown
Member

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@KostyaSha KostyaSha added this to the 3.0.0 milestone Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants