Skip to content

Fix NegativeArraySizeException in awaitCompletion()#487

Merged
KostyaSha merged 1 commit into2.xfrom
fixCompletion2.x
Mar 1, 2016
Merged

Fix NegativeArraySizeException in awaitCompletion()#487
KostyaSha merged 1 commit into2.xfrom
fixCompletion2.x

Conversation

@KostyaSha
Copy link
Copy Markdown
Member

@KostyaSha KostyaSha commented Feb 29, 2016

The same logic as in next if branch for .read()

Review on Reviewable

@KostyaSha KostyaSha added this to the 2.2.3 milestone Feb 29, 2016
@KostyaSha
Copy link
Copy Markdown
Member Author

KostyaSha commented Feb 29, 2016

No idea/time for test case :( But obviously should be right and checked on master/1.22 branch...

@KostyaSha
Copy link
Copy Markdown
Member Author

KostyaSha commented Mar 1, 2016

@marcuslinke ?

@marcuslinke
Copy link
Copy Markdown
Contributor

marcuslinke commented Mar 1, 2016

No need for a test case as this will fail with 1.22 nevertheless. This should be cherry-picked to master branch also.

@KostyaSha
Copy link
Copy Markdown
Member Author

KostyaSha commented Mar 1, 2016

#486 is for master

@KostyaSha
Copy link
Copy Markdown
Member Author

KostyaSha commented Mar 1, 2016

@marcuslinke merge and release?

KostyaSha added a commit that referenced this pull request Mar 1, 2016
@KostyaSha
Merge pull request #487 from docker-java/fixCompletion2.x
14c50a2 
Fix NegativeArraySizeException in awaitCompletion()
@KostyaSha KostyaSha merged commit 14c50a2 into 2.x Mar 1, 2016
@marcuslinke
Copy link
Copy Markdown
Contributor

marcuslinke commented Mar 2, 2016

@KostyaSha Will prepare new releases in the evening.

@KostyaSha KostyaSha deleted the fixCompletion2.x branch March 2, 2016 07:37
@KostyaSha
Copy link
Copy Markdown
Member Author

KostyaSha commented Mar 2, 2016

Released? :)

@marcuslinke
Copy link
Copy Markdown
Contributor

marcuslinke commented Mar 2, 2016

Sure. :-) Both 2.2.3 and 3.0.0-RC2

@KostyaSha
Copy link
Copy Markdown
Member Author

KostyaSha commented Mar 2, 2016

Interesting where is my bintray notification...

@marcuslinke
Copy link
Copy Markdown
Contributor

marcuslinke commented Mar 2, 2016

Whats this bintray? What it can do for us?

@KostyaSha
Copy link
Copy Markdown
Member Author

KostyaSha commented Mar 2, 2016

@marcuslinke more modern way of working with binaries :) And i think it has better permissions scheme so you can upload gpg keys into it and then allow me uploading binaries (that will be signed and uploaded to maven central automatically).
https://bintray.com/bintray/jcenter

In my case i'm only watching repository https://bintray.com/bintray/jcenter/com.github.docker-java%3Adocker-java/view (it syncs from mavencentral i think).

@KostyaSha
Copy link
Copy Markdown
Member Author

KostyaSha commented Mar 2, 2016

Version 2.2.3 of the package com.github.docker-java:docker-java is now available in Bintray!
Appeared! cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type/bug

Projects

None yet

Milestone

2.2.3

Development

Successfully merging this pull request may close these issues.

2 participants

@KostyaSha @marcuslinke